Closed Bug 1369111 Opened 7 years ago Closed 7 years ago

Maintain a live set of active mscom interceptors

Categories

(Core :: Disability Access APIs, enhancement)

Product:
Core
Component:
Disability Access APIs
Platform:
Unspecified
Windows
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

Attachments

(1 file)

Add a live set for mscom::Interceptor
4.79 KB, patch
jimm
: review+
Details | Diff | Splinter Review 
Sometimes we're creating interceptors for objects that are already wrapped because we don't currently have a way to check whether or not there is already an existing interceptor for that object.

If we create a hash table that maps the target object pointer to a weak reference to its interceptor, we can then reuse the interceptor.

This is better for perf and better for object identity correctness.
Attachment #8874901 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/780118d9c79c2a8e8f12724ac7d04b0170f330a7
Bug 1369111: Modify mscom interceptor to maintain a set of weak references to all interceptors that are currently live; r=jimm
https://hg.mozilla.org/mozilla-central/rev/780118d9c79c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: