Minor comparechooser tweaks

RESOLVED FIXED

Status

Tree Management
Perfherder
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(2 attachments)

We should add the "input-group" class to input/button combo so we don't round the left edges of the button.

Comment 1

7 months ago
Created attachment 8873133 [details] [review]
[treeherder] wlach:1369137 > mozilla:master
Comment on attachment 8873133 [details] [review]
[treeherder] wlach:1369137 > mozilla:master

Noticed this while testing the new comparison viewer. It's a simple CSS fix-- bootstrap varies the display of the "button" class depending on the presence/absence of the "input-group" class on either it or a parent element. I'll attach screenshots to the github pr.
Attachment #8873133 - Flags: review?(shrutijasoria1996)
Comment on attachment 8873133 [details] [review]
[treeherder] wlach:1369137 > mozilla:master

The way you catch such minute nits amazes me.
Attachment #8873133 - Flags: review?(shrutijasoria1996) → review+

Comment 4

7 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/77c41ae7d03cae1f937ad56b88b3edd5f2736a06
Bug 1369137 - Fix styling of "recent" buttons in compare chooser (#2523)
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED

Comment 5

6 months ago
Created attachment 8874591 [details] [review]
[treeherder] wlach:1369137-followup > mozilla:master
The earlier commit introduced a formatting problem in the compare chooser-- not sure how I missed that. Filed a follow-up PR to fix that,
Summary: Styling of "recent" button in comparechooser is slightly off → Minor comparechooser tweaks
(In reply to William Lachance (:wlach) (use needinfo!) from comment #6)
> The earlier commit introduced a formatting problem in the compare chooser--
> not sure how I missed that. Filed a follow-up PR to fix that,

... and also add a bit of help text in the chooser (just to make sure people understand how things work now)

Comment 8

6 months ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6dd96f825848c0b3d44ac1b3ba64ae7385f201f3
Bug 1369137 - Fix formatting of compare chooser dialog

https://github.com/mozilla/treeherder/commit/542c93317bb709a5e5680b97cfa907edf18d0bfc
Bug 1369137 - Add a help string about new sampling-based comparison
You need to log in before you can comment on or make changes to this bug.