Closed
Bug 1369147
Opened 7 years ago
Closed 7 years ago
Flash SHIELD study updates for week 4 recruitment
Categories
(Core Graveyard :: Plug-ins, enhancement)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Unassigned)
References
Details
I'd like to make the following changes to the Flash study before we do week 4 recruitment: 1) implement the equivalent functionality of plugins.remember_infobar_dismissal == true from bug 1368060: * if the user clicks the "x" on the infobar, remember that decision and don't ever show the infobar again for that site If it's not too hard, it would be nice to collect data about these dismissals in addition to the allow/block counts we already have. 2) block a set of domains from ever triggering infobars. (hardcoded list for the study) Suppress infobars in the following cases: * this site or any subdomain is loaded as the toplevel page and that site or any subframe triggers an infobar * this site or any subdomain is loaded as an iframe and triggers an infobar Site list: yandex.ru chpoking.ru ok.ru amazon.com amazon.co.jp paypal.com amazon.fr twitch.tv ebay.com aol.com
Comment 1•7 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #0) > Site list: > ... > paypal.com paypal.com is on the 1st-party blocklist, so it won't be displaying any infobars anymore. Or are you planning on removing it from that list?
Reporter | ||
Comment 2•7 years ago
|
||
Oh I missed that. Then no need to add paypal to this. We may flip those around in the future depending on feedback from paypal engineering.
Comment 3•7 years ago
|
||
Felipe, would you mind reviewing this? https://github.com/squarewave/shield-study-essential-flash/commit/b1af90211095d93a70dde5d3fd7a5a9b50f77b06
Flags: needinfo?(felipc)
Comment 4•7 years ago
|
||
Felipe reviewed. Submitting update to AMO. Quick note: the version of the ping payload has been bumped to 3.
Flags: needinfo?(felipc)
Comment 5•7 years ago
|
||
Update approved on AMO
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•