1369152 - Update webrender to b2614e4eb58f9dee08b8c38f96bc3bac834c837b

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1367734 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ e9b0ac42382af159f5ae62526b94399e01cf50a8

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44e1dbfb6e67dfa6c7430706d0349ad54f21867e

Green

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ f12ce8b1481e3ba1e0fb585d84c3d907dab5ff7e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2a321377fb68ecc5271cdb9515c4b97e2c34146
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f57f6145529471dcd99ec095e12a86dca5b2439e

Green on linux64, shader compilation error on windows. I filed servo/webrender#1332 for the shader problem.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ bac0976528e121f085ea66573eb9da30973a3a41

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8cf7368b6597c02e6ba822281f4de6e25a62de93
https://treeherder.mozilla.org/#/jobs?repo=try&revision=33ce9caddc3b946cab559ae82d49240a6a80d372

Some reftest failures:
TEST-UNEXPECTED-PASS | layout/reftests/w3c-css/submitted/images3/object-position-png-001c.html
TEST-UNEXPECTED-PASS | ayout/reftests/w3c-css/submitted/images3/object-position-png-002c.html
TEST-UNEXPECTED-FAIL | layout/reftests/box-shadow/boxshadow-large-border-radius.html 
TEST-UNEXPECTED-FAIL | layout/reftests/css-break/box-decoration-break-with-inset-box-shadow-1.html

First two are good, I guess. The third and fourth are increases in fuzziness of already-fuzzy tests.

Regression range:
* bac0976 Auto merge of #1331 - glennw:snap-fix, r=kvark
* afa7ac8 Don't apply local clip rect to snap rectangle calculation.

Therefore must be from servo/webrender#1331

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 4f1eadb86397787c18f1e89797026813bc3643ee

https://treeherder.mozilla.org/#/jobs?repo=try&revision=37efba8059d4ef8d2db242c1704a86b32bf6ae29
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6dc7c0aba9869369a2aab470648577b85b13c09f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf23a8f80e0757da8f87cc51458a2828cd6e4fcb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2942780d53c6c093fed9cd2f0be76bbbfea80998
https://treeherder.mozilla.org/#/jobs?repo=try&revision=97587754bc9534cff58828a45182f0122d2a8584
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a80c996c601bd2ce968183c0a8bc4811f5928ac
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad63afa3885335cbf9c8822329280c976281969b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=699030f63261b1189bbfc5b1402ecb3f6d74f25f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbcad7511b916e0050230c4f2f72d06ea23b8921
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c357983e7ac619ea6438570386e72ddb3c133cbe

(These are the various pushes my cron job ran over the weekend - all have the same WR version but are based on different m-c revs). No new failures, same stuff as in comment 3.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ b2614e4eb58f9dee08b8c38f96bc3bac834c837b

https://treeherder.mozilla.org/#/jobs?repo=try&revision=02ba394542675cac737ca213bc7e2b6bb43776a2
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fe87f9cffb200966a770b77081d74f043acba38

I had fuzzed the R1/R3/R4 failures but it looks like the changes were reverted, so my fuzz changes are now causing the failures. I'll drop the fuzzing changes and things should be green again. Still waiting on those windows jobs to see if they fix the shader compilation failures.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

The win8 jobs look like they're back to the ANGLE assertion on debug, so the shader compilation issue appears fixed. We should land this update and push it out.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1369152 - Update webrender to cset b2614e4eb58f9dee08b8c38f96bc3bac834c837b.

Review commit: https://reviewboard.mozilla.org/r/145914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145914/

Comment 8

[Kartikaya Gupta (email:[e-mail])]

One more try push just to make sure (there was a heapsize version bump in the previous try push that we don't need): https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2211ad01ce8878bd222dd2740faecc8b1c8e4e8

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8874573 [details]
Bug 1369152 - Update webrender to cset b2614e4eb58f9dee08b8c38f96bc3bac834c837b.

https://reviewboard.mozilla.org/r/145914/#review149848

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6fa08f52247
Update webrender to cset b2614e4eb58f9dee08b8c38f96bc3bac834c837b. r=jrmuizel

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b6fa08f52247