Closed Bug 1369159 Opened 4 years ago Closed 4 years ago
Crash when saving JSON
# Variant 1 1. Open Firefox in e10s mode 2. Load data:application/json,[1,2,3] 3. Click Save button (then you can cancel the dialog) 4. Open a new tab 5. Open a new window 6. Load data:application/json,[1,2,3] 7. Click Save button Result: - The whole browser crashes https://crash-stats.mozilla.com/report/index/5568c8ab-597b-42c1-866a-9fba80170531 # Variant 2 Like variant 1, but skip step 4. Result: - The tab in the old window crashes https://crash-stats.mozilla.com/report/index/4bba79eb-cf16-47ea-a5bb-b62700170531 - Save dialog does not open - The browser console shows this error: NS_ERROR_FAILURE: saveBrowser failed asynchronously in startPersistence # Variant 3 Like variant 1 or 2, but without e10s. Result: - No crash :) - Save dialog does not open - The browser console shows this error: NS_ERROR_FAILURE: saveBrowser failed asynchronously in startPersistence I guess I shouldn't have tried to reuse the same window in bug 1327784, but a crash is surprising.
Small fix, seems to fix the problem. I attempted to load contentAreaUtils in converter-child.js and save there. I managed to get the save dialog, but then it didn't save. So meanwhile, this patch is better.
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
Attachment #8873190 - Flags: review?(odvarko)
The underlying issue behind the crash is bug 1369246, but the JSON Viewer needs to be fixed in order to be able to save in the cases described in comment 0.
While I'm at it, removing some unused code leftover after bug 1327784.
Comment on attachment 8873407 [details] [diff] [review] json-save-fixcrash-v2.patch Review of attachment 8873407 [details] [diff] [review]: ----------------------------------------------------------------- Fixes the problem, thanks! R+ Honza
Attachment #8873407 - Flags: review?(odvarko) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5f83e3e0c2ed Do not reuse the chrome window when saving in JSON Viewer. r=Honza
You need to log in before you can comment on or make changes to this bug.