Closed Bug 1369168 Opened 2 years ago Closed 2 years ago

Fix GeckoView multiple select prompt

Categories

(GeckoView :: General, enhancement)

50 Branch
Unspecified
Android
enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

There are some bugs in the GeckoView prompt for multiple-choice select fields.
1) Fix a crash when sending back prompt results.
2) Restrict results to <option> elements.
3) Correctly report invalid results.
4) Correctly pre-check selected items.
5) Display Ok/Cancel buttons.
Attachment #8873162 - Flags: review?(droeh)
Attachment #8873162 - Flags: review?(droeh) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a99686b566a
Fix GeckoView multiple select prompt; r=droeh
https://hg.mozilla.org/mozilla-central/rev/6a99686b566a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.