136917 - FilePicker convert path incorrectly

Status: RESOLVED INCOMPLETE

(Core :: XUL, defect, P4)

Description

[rods (gone)]

If you call SetDefaultString with "p:\p.ps" it gets converted to "p-\p.ps"

Comment 1

[rods (gone)]

Attachment: patch

This patch cuts off the the disk part and calls
ReplaceChar(FILE_ILLEGAL_CHARACTERS, '-') on just the name instead of the
entire string.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 78738 [details] [diff] [review]
patch

that looks wrong to me. why don't you simply start replacing at the third
character, because you can't specify a driver after that anyway. furthermore,
you might want to make that #ifdef XP_WIN32 or what that's called

Comment 3

[Joey Connick]

I'm seeing this in Thunderbird 1.0 when I Save All attachments and one (or more)
of the files already exists.  I choose not to overwrite it and the path that
shows up in the resultant filepicker generates
f-\path\to\the\saveall\directory\existing.filename instead of
f:\path\to\the\saveall\directory\existing.filename

Actually, I've seen it in recent older Thunderbird versions, too (0.8, 0.9).

Comment 4

[Andrei Purice]

Marking this as Resolved > Incomplete since the last real activity on this issue was 17 years ago (reported for Windows 2000) and it might not be relevant anymore.
Feel free to re-open it if it's not the case and the issue is still relevant.