136919 - TestColorNames is broken

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect, P4)

Description

[timeless]

i'm running these tests on QNX and FreeBSD hence pc/all
There are two problems, I have a fix for the second problem which is:
bug: can't find ''
bug: name='' id=-1 index=56
###!!! ASSERTION: no lookup table, needs addref: 'gColorTable', file /home/timeless/mozilla/gfx/src/nsColorNames.cpp, line 108
###!!! Break: at file /home/timeless/mozilla/gfx/src/nsColorNames.cpp, line 108
bug: name='' didn't NS_ColorNameToRGB
bug: name='' ColorNameToRGB=28061000 kColors[-13631571]=ff2fffad
bug: rgb=28061000 hexrgb=ff061000

Comment 1

[timeless]

Attachment: it's an error if the string is empty, so error early instead of making a mess

Comment 2

[timeless]

The first problem is:
~/mozilla/obj-xlib-i386-unknown-freebsd4.4/dist/bin: ./r*h ./T*C*mes
###!!! ASSERTION: no lookup table, needs addref: 'gColorTable', file /home/timeless/mozilla/gfx/src/nsColorNames.cpp, line 118
###!!! Break: at file /home/timeless/mozilla/gfx/src/nsColorNames.cpp, line 118

Comment 3

[timeless]

Attachment: initialize the color table

And if you initialize the color table, everything works, i guess

Comment 4

[Darin Fisher]

Comment on attachment 78740 [details] [diff] [review]
initialize the color table

Index: TestColorNames.cpp

>     nsCString tagName(nsColorNames::GetStringValue(index));
>+    if (tagName.Length()==0) {
>+      printf("bug: tagName for nsColorNames::GetStringValue(%d) is ''\n", index);
>+      rv = -1;
>+      continue;
>+    }

tagName.IsEmpty() to say what you mean.  you should get pavlov or someone with
more
module ownership than myself to review this.

Comment 5

[timeless]

doh, fixed in tree, I always try to use isEmpty(), have it fail and fallback to 
Length() ... silly case sensitive ...

peterL: you appear to be the only person in log who made real changes who might 
still be alive, can you r?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 78740 [details] [diff] [review]
initialize the color table

Get this off dbaron's plate. r=roc+moz

Comment 7

[timeless]

.

Comment 8

[timeless]

checked in