Don't use nsISelection::CollapseNative / ExtnedNative

RESOLVED FIXED in Firefox 55

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

55 Branch
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Editor only uses CollapseNative and ExtendNative even if it uses Selection, not nsISelection.  CollapseNative and ExtendNative is virtual method, but Selection::Collapse and Extend is non-virtual.  So we should use Selection::Collapse and Extend instead.
Comment on attachment 8873754 [details]
Bug 1369252 - Don't use nsISelection::CollapseNative / ExtendNative.

https://reviewboard.mozilla.org/r/145170/#review149128

::: commit-message-aeb3d:3
(Diff revision 1)
> +Bug 1369252 - Don't use nsISelection::CollapseNative / ExtendNative. r?masayuki
> +
> +Editor still uses CollapseNative and ExtendNative even if it uses Selection, not nsISelection.  CollapseNative and ExtendNative is virtual method, but Selection::Collapse and Extend is non-virtual.  So, we should use Selection::Collapse and Extend instead.

nits:

s/CollapseNative and ExtendNative is/CollapseNative and ExtendNative are
s/Selection::Collapse and Extend is/Selection::Collapse and Selection::Extend are
Attachment #8873754 - Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/d3888af691ae
Don't use nsISelection::CollapseNative / ExtendNative. r=masayuki
https://hg.mozilla.org/mozilla-central/rev/d3888af691ae
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee: nobody → m_kato
You need to log in before you can comment on or make changes to this bug.