1369252 - Don't use nsISelection::CollapseNative / ExtnedNative

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

Editor only uses CollapseNative and ExtendNative even if it uses Selection, not nsISelection.  CollapseNative and ExtendNative is virtual method, but Selection::Collapse and Extend is non-virtual.  So we should use Selection::Collapse and Extend instead.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1369252 - Don't use nsISelection::CollapseNative / ExtendNative.

Editor still uses CollapseNative and ExtendNative even if it uses Selection, not nsISelection.  CollapseNative and ExtendNative is virtual method, but Selection::Collapse and Extend is non-virtual.  So, we should use Selection::Collapse and Extend instead.

Review commit: https://reviewboard.mozilla.org/r/145170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145170/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8873754 [details]
Bug 1369252 - Don't use nsISelection::CollapseNative / ExtendNative.

https://reviewboard.mozilla.org/r/145170/#review149128

::: commit-message-aeb3d:3
(Diff revision 1)
> +Bug 1369252 - Don't use nsISelection::CollapseNative / ExtendNative. r?masayuki
> +
> +Editor still uses CollapseNative and ExtendNative even if it uses Selection, not nsISelection.  CollapseNative and ExtendNative is virtual method, but Selection::Collapse and Extend is non-virtual.  So, we should use Selection::Collapse and Extend instead.

nits:

s/CollapseNative and ExtendNative is/CollapseNative and ExtendNative are
s/Selection::Collapse and Extend is/Selection::Collapse and Selection::Extend are

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8873754 [details]
Bug 1369252 - Don't use nsISelection::CollapseNative / ExtendNative.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145170/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3888af691ae
Don't use nsISelection::CollapseNative / ExtendNative. r=masayuki

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d3888af691ae