1369281 - Firefox UI display as zh-CN locale while android system locale is in zh-TW

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Locale switching and selection, defect, P1)

Description

[Max Liu [:maliu]]

STR:
* Set android system locale to zh-TW;
* Kill firefox process and launch;
* Observe UI locale in option menu and Settings

ER:
* UI display in zh-TW

AR:
* UI display in zh-CN


UI will be correct if user switched system locale, and it can be reproduced when process killed, cold start;

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Peter, could you comment on what you saw on your phone? This is pretty severe and I think we should fix it sooner or later. Thanks!

Comment 2

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

From what I observe, Fennec displays in zh-CN when 繁體中文（台灣） has a higher order than 中文（台灣）in android locale preference. However if 中文（台灣） is more preferred, UI will display in zh-TW without problem.

Moreover, it seems that it's only possible to set 中文（台灣）in the first run UI, or being migrated from older android versions; if I remove that preference I'm unable to re-add it back, 繁體中文（台灣） still exists though. 

I also noticed that when this bug happens, about: page in Fennec as well as some UI messages still displays in English, a normal zh-CN build should have these messages localized. 


Other Information:
Device: Google Nexus 5X
Android Version: 7.1.2 (N2G47O)
Fennec Version: 53.0.2

Comment 3

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Just fyr for in case someone reading this bug do not read localized locale names: 
繁體中文（台灣） literally is Traditional Chinese (Taiwan), and 中文（台灣） is Chinese (Taiwan). 

I suspect 繁體中文（台灣） is zh-Hant-TW, and 中文（台灣）should be zh-TW, but unfortunately I do not have android development environment in handy to confirm.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late to fix this in 53, but if 54 is affected, we might still be able to fix the issue for 54 in a dot release. We need to know if we still see the issue in 54 and 55.   

Escalating to Joe and Tim since this may be a serious issue for Fennec, and if so, we should put resources into fixing it as soon as we can.

Comment 5

[Max Liu [:maliu]]

Attachment: Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),

Review commit: https://reviewboard.mozilla.org/r/147088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147088/

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),

https://reviewboard.mozilla.org/r/147088/#review151250

LGTM

Comment 7

[Max Liu [:maliu]]

Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147088/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b977e23d261c
Simplify Locale setting string without variant/script which is from Locale.toString(), r=nechen

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Talked to Max offline and he landed the patch. Thanks :)

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b977e23d261c

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please remember to ask for uplift.

Comment 12

[Max Liu [:maliu]]

Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),

Approval Request Comment
[Feature/Bug causing the regression]: RTL Locale Switcher.
[User impact if declined]: Cold launch will cause UI fallback to language default without country specific. zh_TW_#Hant -> zh(fallback zh_CN)
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: 
  STR: Switch system locale to zh_TW and force stop fennec, launch fennec and check UI.
  ER: UI display in zh_TW, not zh_CN
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: Serialize locale to string manually with a simplified language_country format.
[String changes made/needed]: No

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),

beta is going to be 55 later today. Updating the request.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Looks like this missed landing for 54.  If we do a dot release, we may want to take this patch.

Comment 15

[Oana Horvath [:ohorvath]]

Verified on Beta 55.0b1, that switching the Android system language to zh-TW 中文（台灣) displays the same language as installing the single locale build from archive http://archive.mozilla.org/pub/mobile/candidates/55.0b1-candidates/build2/android-api-15/zh-TW/. In previous Beta 54, the about:firefox and app settings were displayed in English as it was said in comment 2. This isn't reproducible anymore. 
Verified as fixed.
Device:
-Motorola Nexus 6 (Android 7.0)

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),

Locale fix, we should definitely take this for beta 55.

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),

My mistake, I was reviewing beta uplift requests in another window, and somehow missed this was for release. Leaving this for gchang to review.

Comment 18

[Gerry Chang [:gchang]]

Comment on attachment 8875665 [details]
Bug 1369281 - Simplify Locale setting string without variant/script which is from Locale.toString(),

Locale fix. We're gonna take this one in 54.0.1.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/a93674bcfade

Comment 20

[Bogdan Surd, QA [:bsurd, NI]]

Devices:
 - Nexus 5 (Android 6.0.1);
 - LG G4 (Android 6.0);
 -Asus ZenPad 8.0 Z380KL (Android 6.0.1);
Build:
 - 54.0.1

Hello,
 I've verified this using multiple devices and the issue was no longer reproducible. Marking as verified.

Comment 21

[Chris Peterson [:cpeterson]]

Removing regressionwindow-wanted keyword because this bug has been resolved.

Comment 22

[Chris Peterson [:cpeterson]]

Removing regressionwindow-wanted keyword because this bug has been resolved.

Comment 23

[Chris Peterson [:cpeterson]]

Removing regressionwindow-wanted keyword because this bug has been resolved.