Closed
Bug 1369292
Opened 7 years ago
Closed 7 years ago
Cannot run config.status on certain build system such as Yocto
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: ashie, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
On certain build systems such as Yocto, config.status is failed to run due to a too long shebang which is embedded in the top of the file. The max length of shebang on Linux is 128 bytes, it's defined in linux/binfmts.h. To avoid it they apply a patch to override the shebang: https://github.com/OSSystems/meta-browser/blob/master/recipes-mozilla/firefox/firefox/fix-python-path.patch But I think the issue can be resolved at upstream by calling python executable explicitly from the shell.
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → ashie
Status: NEW → ASSIGNED
Reporter | ||
Comment 1•7 years ago
|
||
Call python executable explicitly from the shell on running config.status to avoid limit of shebang length.
Attachment #8873339 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8873339 [details] [diff] [review] fix-python-path.path Review of attachment 8873339 [details] [diff] [review]: ----------------------------------------------------------------- This most certainly breaks the build on Windows.
Attachment #8873339 -
Flags: review?(mh+mozilla) → review-
Assignee | ||
Updated•7 years ago
|
Assignee: ashie → mh+mozilla
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8873742 [details] Bug 1369292 - Avoid running config.status in js/src. https://reviewboard.mozilla.org/r/145148/#review149736
Attachment #8873742 -
Flags: review?(mshal) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/6d09d5f53e43 Avoid running config.status in js/src. r=mshal
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6d09d5f53e43
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•