show onboarding overlay in about:home

VERIFIED FIXED in Firefox 55

Status

()

Firefox
New Tab Page
P1
normal
VERIFIED FIXED
3 months ago
3 months ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

unspecified
Firefox 55
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox55 verified)

Details

(Whiteboard: [photon-onboarding])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
we want to show onboarding overlay in about:Home based on PM(pdol)'s new request
(Assignee)

Updated

3 months ago
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Depends on: 1357005
Priority: -- → P1
Whiteboard: [photon-onboarding]
Target Milestone: --- → Firefox 56

Updated

3 months ago
Flags: qe-verify+
QA Contact: jwilliams
Comment hidden (mozreview-request)
(Assignee)

Comment 2

3 months ago
The patch 
1. add the about:Home URL in check list, and 
2. turns `browser.onboarding.disabled` pref to `browser.onboarding.enabled` to align with other prefs (ex: browser.newtabpage.activity-stream.enabled)
Comment hidden (mozreview-request)

Comment 4

3 months ago
mozreview-review
Comment on attachment 8873334 [details]
Bug 1369296 - show onboarding overlay in about:home;

https://reviewboard.mozilla.org/r/144792/#review148886

::: browser/extensions/onboarding/content/onboarding.js:109
(Diff revision 2)
>  
>  addEventListener("load", function(evt) {
>    // Load onboarding module only when we enable it.
> -  if (content.location.href == ABOUT_NEWTAB_URL &&
> -      !Services.prefs.getBoolPref("browser.onboarding.disabled")) {
> +  if ((content.location.href == ABOUT_NEWTAB_URL ||
> +       content.location.href == ABOUT_HOME_URL) &&
> +      Services.prefs.getBoolPref("browser.onboarding.enabled")) {

Can you add a default to this getBoolPref call while you're here, just in case we want to use the system add-on in a version of Firefox without the default set.
Attachment #8873334 - Flags: review?(dtownsend) → review+

Comment 5

3 months ago
mozreview-review
Comment on attachment 8873334 [details]
Bug 1369296 - show onboarding overlay in about:home;

https://reviewboard.mozilla.org/r/144792/#review149086

Looks good to me with one change needed.

::: browser/extensions/onboarding/content/onboarding.js:108
(Diff revision 2)
>  }
>  
>  addEventListener("load", function(evt) {
>    // Load onboarding module only when we enable it.
> -  if (content.location.href == ABOUT_NEWTAB_URL &&
> -      !Services.prefs.getBoolPref("browser.onboarding.disabled")) {
> +  if ((content.location.href == ABOUT_NEWTAB_URL ||
> +       content.location.href == ABOUT_HOME_URL) &&

Can we whitelist UITour on browser/app/permissions too?
Attachment #8873334 - Flags: review?(rexboy) → review+
(Assignee)

Comment 6

3 months ago
mozreview-review-reply
Comment on attachment 8873334 [details]
Bug 1369296 - show onboarding overlay in about:home;

https://reviewboard.mozilla.org/r/144792/#review149086

> Can we whitelist UITour on browser/app/permissions too?

Thanks for review! uitour is is already whitelist about:home on browser/app/permissions
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 9

3 months ago
issue addressed, thanks!
Keywords: checkin-needed

Comment 10

3 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83fd58922970
show onboarding overlay in about:home;r=mossop,rexboy
Keywords: checkin-needed

Comment 11

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/83fd58922970
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: Firefox 56 → Firefox 55
Depends on: 1369750

Comment 12

3 months ago
I can see onboarding overlay in about:home in latest nightly in  Ubuntu 16.04(64 Bit).

Build ID   : 20170607100302

User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [bugday-20170607]

Comment 13

3 months ago
I can see onboarding overlay in about:home in latest nightly  55.0a1 (2017-06-06)(32-bit) in windows 10

Build ID   : 20170606030207

Mozilla/5.0 (Windows NT 10.0; rv:55.0) Gecko/20100101 Firefox/55.0

Comment 14

3 months ago
As per Comment 12 and Comment 13, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.