Hang when loading blob URLs from indexedDB

RESOLVED FIXED in Firefox 55

Status

()

Core
DOM: File
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: darktrojan, Assigned: baku)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 months ago
Created attachment 8873380 [details]
test.zip

As I mentioned on IRC, I think this is to do with bug 1366316. It also seems to be related to webExtensions.

I've attached a basic extension which causes the hang for me. You should be able to load this through about:debugging then get to moz-extension://something/test.html. Choose a picture with the file input and watch it hang.
(Assignee)

Updated

5 months ago
Assignee: nobody → amarchesini
(Reporter)

Updated

5 months ago
Assignee: amarchesini → nobody
Flags: needinfo?(amarchesini)
(Assignee)

Comment 1

5 months ago
Created attachment 8873385 [details] [diff] [review]
deadlock.patch
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8873385 - Flags: review?(bugs)
(Assignee)

Comment 2

5 months ago
Comment on attachment 8873385 [details] [diff] [review]
deadlock.patch

Review of attachment 8873385 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/file/ipc/IPCBlobInputStreamStorage.cpp
@@ +126,5 @@
> +
> +  nsCOMPtr<nsIInputStream> inputStream;
> +
> +  // NS_CloneInputStream cannot be called when the mutex is locked because it
> +  // can, recursively call GetStream() in case the child lives on the parent

child actor
Attachment #8873385 - Flags: review?(bugs) → review+

Comment 3

5 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ba5835bb00f
Avoid deadlock in IPCBlobInputStreamStorage::GetStream when IPCBlobInputStreamChild actor is used on the parent process, r=smaug

Comment 4

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7ba5835bb00f
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.