1369399 - [Project Dawn] Firefox Developer Edition 54b12 disables e10s

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Kenny D]

Attachment: Firefox asking for a restart on a WebExtension.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170529025115

Steps to reproduce:

1. Download or upgrade to Firefox Developer Edition 54b12


Actual results:

E10s is disabled without any message in about:troubleshooting saying 0/1 (Disabled)


Expected results:

E10s should not be disabled even with no addons or compatible addons.

Also another side effect is that force-enabling e10s causes any installed/updated addon (even WebExtensions) to ask for a Firefox restart. See screenshot.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

This sounds troublesome. I could see there being differences in e10s status now that RELEASE_OR_BETA is set for DevEdition when it wasn't previously.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Thanks for noticing this, Kenny!

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1369399 - Re-enable e10s for DevEdition.

I thought of fixing this in the e10srollout addon because DevEdition is now
built off of Beta, but it would only serve to complicate the addon even more
and expose us to more risk every time we touch it. Also, DevEdition stayed on
the Aurora update channel and who knows if we're going to change that in the
future. Special casing DevEdition (via AppConstants) is possible, but it was
going to get messy pretty quickly. This is probably the most straightforward
way to make this all work.

Review commit: https://reviewboard.mozilla.org/r/146414/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146414/

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8875043 [details]
Bug 1369399 - Re-enable e10s for DevEdition.

https://reviewboard.mozilla.org/r/146414/#review150408

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85b383c5a7a8
Re-enable e10s for DevEdition. r=Felipe

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/85b383c5a7a8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

DevEdition is moving to Gecko 55 next week and we're already in the release candidate phase of 54, so we won't be fixing DevEdition 54 at this point.

Comment 8

[Kenny D]

Does this patch also fix the WebExtension restarting issue or is it something else?

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Yes, this also fixes the WebExtension restarting issue (as far as I can tell).

Comment 10

[Kenny D]

I tested these builds here on a new profile and there's still some problems.

https://archive.mozilla.org/pub/devedition/candidates/55.0b1-candidates/

The good news is e10s is still enabled on a new profile but WebExtensions are still asking for a restart (WebExtensions don't ask for a restart in non-e10s mode).

Also e10s can be disabled by a WebExtension using these STR on a new profile:

1. Install 55b1 candidate builds
2. Open up 55b1 Developer Edition and install a WebExtension
3. The WebExtension will ask for a restart. Click Restart.
4. Firefox restarts (e10s is still enabled)
5. Exit and Open up Firefox again (2nd restart)

After step 5, e10s is disabled saying this time in about:troubleshooting (0/1) Disabled by addons, despite only having a WebExtension.

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

I can reproduce that. I don't know how I didn't reproduce it before. I'll file a new bug for it.