1369471 - Regression selecting an entire directory of tests on the command line

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[James Graham [:jgraham]]

|mach wpt| should allow selecting an entire directory of tests using a path like |mach testing/web-platform/tests/dom|. But that regressed in an upstream patch to use O(1) access to test files where a full path is supplied rather than iterating the entire manifest. For directories we still need to iterate over everything.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1369471 - Allow running wpt directories by path on the command line,

We regressed running entire directories when wptrunner was switched to
look up command parameters directly in the manifest rather than
iterating over prefix matches. For files that's OK, but for
directories the old behaviour is required.

Review commit: https://reviewboard.mozilla.org/r/144930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144930/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8873544 [details]
Bug 1369471 - Allow running wpt directories by path on the command line,

https://reviewboard.mozilla.org/r/144930/#review149232

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5baa39559276
Allow running wpt directories by path on the command line, r=maja_zf

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5baa39559276