13695 - [DOGFOOD] Window close box needs to call JS close routines

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[sujay]

using 9/13 build of apprunner

1) launch apprunner
2) launch editor
3) open a new blank window
4) type some chars in it.
5) close the window by clicking in upper right hand corner "X".

Notice no save dialog/panel comes up

all platforms.

additional comments from Charley's mail message:

"But I do notice that you can use the Window's "X" to
close the window. Is that why you reported failing on that item? We have no
control over that in the editor. To fix that problem, someone in XPFE widgets
or XPApps (whoever owns window management) needs to help us wire up the
close-window message to do the same as "Close" on the menu."

Comment 1

[Simon Fraser [no longer active]]

This bug describes a more general problem, in that we need to have some kind of
JS handler called when the user clicks the close box in the native window frame.
Note that responding to this click may, in fact, abort the closing of the window
(e.g. the user could cancel saving a modified document).

Comment 2

[leger]

Setting to M12 per buster

Comment 3

[sujay]

Also wanted to add that windows shortcut Alt-F4 is also problematic
in that it doesn't prompt a save dialog/panel just like "x" close ..

Comment 4

[sujay]

*** Bug 17007 has been marked as a duplicate of this bug. ***

Comment 5

[Peter Trudelle]

mass-moving all m12 bugs to m13

Comment 6

[Simon Fraser [no longer active]]

Marking dogfood. This bug can cause serious data loss in editor.

Comment 7

[leger]

Putting on PDT+ radar.

Comment 8

[Peter Trudelle]

pulling back to m12

Comment 9

[Jim Roskind]

Reformatted date field, without changing value

Comment 10

[Dan M]

Can't read date field, which has naked numbers in arbitrary order. Deleting.

Oh, well, and the bug is fixed, at least from my end. If the mood strikes you, you can now add
a "close" event handler to a window, much as you've always been able to have "unload" handlers.
The close event fires before the window actually closes, and its handler has an opportunity to
abort window closure (by returning false, the same as link click event handlers.)

Comment 11

[Charles Manske]

Since the critical need for this to be fixed is for the editor, where the user
can click on the "X" and close the window, loosing all of their changes, and
thus I need to add the appropriate "close" handler to the editor to finish
fixing the problem, I'm reopening this and assigning to me to finish this work.

Comment 12

[rubydoo123]

adding composer pdt+ tracking

Comment 13

[Charles Manske]

Adding target date for fix as this Friday

Comment 14

[Charles Manske]

The editor work is checked in.
Passing back to Dan to let him mark as fixed.

Comment 15

[sujay]

verified in 12/6 build.