Closed Bug 1369538 Opened 3 years ago Closed 3 years ago

Add telemetry about MediaCacheStream lengths

Categories

(Core :: Audio/Video: Playback, enhancement)

55 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(1 file)

One idea of avoid file IOs would be to keeo "small-enough" media resources completely in memory.
This probe will help us judge if this could actually be beneficial.
Comment on attachment 8873654 [details]
Bug 1369538 - Telemetry MEDIACACHESTREAM_LENGTH_KB -

https://reviewboard.mozilla.org/r/145040/#review148998

datareview+

::: toolkit/components/telemetry/Histograms.json:8408
(Diff revision 1)
> +    "bug_numbers": [1369538],
> +    "expires_in_version": "60",
> +    "kind": "linear",
> +    "high": 520000,
> +    "n_buckets": 66,
> +    "description": "MediaCacheStream stream length size in KB; Either known size (from HTTP header), or otherwise actually downloaded. Recorded at every MediaCacheStream destruction."

What determines whether it's the known size of the actual download?

Is it the presence of the header?

If so, you could rephrase that part to "Either known size from the HTTP header, if available, or otherwise the size actually downloaded."
Attachment #8873654 - Flags: review?(francois) → review+
Comment on attachment 8873654 [details]
Bug 1369538 - Telemetry MEDIACACHESTREAM_LENGTH_KB -

https://reviewboard.mozilla.org/r/145040/#review148998

> What determines whether it's the known size of the actual download?
> 
> Is it the presence of the header?
> 
> If so, you could rephrase that part to "Either known size from the HTTP header, if available, or otherwise the size actually downloaded."

Done, it's a bit clearer now, thanks for the suggestion.
Comment on attachment 8873654 [details]
Bug 1369538 - Telemetry MEDIACACHESTREAM_LENGTH_KB -

https://reviewboard.mozilla.org/r/145040/#review149008
Attachment #8873654 - Flags: review?(cpearce) → review+
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12e990a89018
Telemetry MEDIACACHESTREAM_LENGTH_KB - r=cpearce,francois
Thank you François and Chris for the review.
sorry gerald had to back this out for causing https://treeherder.mozilla.org/logviewer.html#?job_id=103988064&repo=autoland
Flags: needinfo?(gsquelart)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c552b68a1c94
Backed out changeset 12e990a89018 for causing new intermittent leak in browser_devices_get_user_media_in_frame.js
I doubt this patch could have caused this, as it's just reporting a number to Telemetry.

As further proof, the same intermittent leak continues after the backout, e.g., the most appearance (5h ago) is in:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8814375529f130f680f1257c14a678bbc65ce440
This intermittent is now followed by bug 1369731.

So I will reland.
Flags: needinfo?(gsquelart)
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7e36fe5ac72
Telemetry MEDIACACHESTREAM_LENGTH_KB - r=cpearce,francois
https://hg.mozilla.org/mozilla-central/rev/a7e36fe5ac72
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1371205
You need to log in before you can comment on or make changes to this bug.