Open Bug 1369541 (omtp) Opened 3 years ago Updated 2 years ago

[meta] Off Main Thread Painting Redux

Categories

(Core :: Graphics: Layers, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: dvander, Unassigned)

References

(Depends on 6 open bugs, Blocks 1 open bug)

Details

(Keywords: meta, Whiteboard: [gfx-noted])

This is a meta bug for take 2 of OMTP. See bug 1256578 for Jerry's earlier work on OMTP. Most of the problems encountered there still apply.
Whiteboard: [gfx-noted]
Depends on: 1383767
Blocks: 1381385
Depends on: 1390295
Depends on: 1390755
Latest try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=74c059a0033ad236c47a655aa8973eb7f8b2788e

Latest status since I'm on PTO. There are three main blocking issues left:

1) Direct2D performance still doesn't make sense, this is bug 1387327. Some amount of investigation went in bug 1392453. This seems to happen across multiple GPU types as well.
2) Skia OMTP still has some reftest failures where it looks like the buffer is getting corrupt. The tests are mostly /layout/reftests/position-dynamic-changes/relative/move-right-bottom.html
3) Leakcheck failures - OMTP seems to be leaking textures somehow but I haven't been able to track these down.
Depends on: 1396474
It looks like the latest try run is green except from a tiny rounding error in Skia on Linux (1 difference of 1 pixel), which should just be fuzzed. So except for possible performance considerations (I've fired off a Talos run) we should be good to go.
(In reply to Bas Schouten (:bas.schouten) from comment #15)
> It looks like the latest try run is green except from a tiny rounding error
> in Skia on Linux (1 difference of 1 pixel), which should just be fuzzed. So
> except for possible performance considerations (I've fired off a Talos run)
> we should be good to go.

Looks like I was wrong, there's one intermittent test failure on Linux -debug- builds. Ryan, could you have a look at that? Note that this doesn't bar us from switching it on on windows.
Flags: needinfo?(rhunt)
Depends on: 1397083
I'm having a difficult time reproducing the intermittent test failure. I've filed bug 1397083 to track it.
Flags: needinfo?(rhunt)
Depends on: 1400299
Latest try run with OMTP enabled:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0df9bcbbd3d4cc9d182debdcd3aa6df58756d83

There are some new failures.
1. Crashes in mozilla::ipc::MessageChannel::Send (this is bug 1400299)
2. R8 failed reftest-no-paint
3. failure in layout/reftests/text/color-opacity-rtl-1.html and color-opacity-rtl-2.html
4. leakcheck | gpu process: 128 bytes leaked (TextureHost, TextureSource, TextureSourceProvider, nsTArray_base)

Some of them probably have the same root cause.
Depends on: 1401638
Latest try run with OMTP enabled:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b66f20de76828074df3c1fa281d4d4237e358ec5

One issue carried over, the rest were resolved.

1. leakcheck | gpu process: 128 bytes leaked (TextureHost, TextureSource, TextureSourceProvider, nsTArray_base)
Depends on: 1416941
Depends on: 1419586
Depends on: 1422392
Depends on: 1424399
Depends on: 1425056
Depends on: 1430793
Depends on: 1430550
Depends on: 1432531
Depends on: 1433266
Depends on: 1438551
Depends on: 1454978
Depends on: 1466146
Depends on: 1467151
Depends on: 1454980
Depends on: 1471261
Depends on: 1471639
Depends on: 1471704
Depends on: 1478815
Depends on: 1480221
Depends on: 1482956
Depends on: 1483245
Depends on: 1483436
Depends on: 1485712
You need to log in before you can comment on or make changes to this bug.