Synced Tabs button has old "spinner" icon when in the toolbar

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
3 months ago
14 hours ago

People

(Reporter: markh, Assigned: eoger)

Tracking

({regression})

Trunk
Firefox 55
regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed, firefox57 verified)

Details

(Whiteboard: [fxsync] [photon-visual])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

3 months ago
Look at the "Synced Tabs" button in either the hamburger menu or "customize" area - notice how it looks like a tab icon. Move the button to the toolbar - note how it is now the "old" sync spinner icon. It should be the tab icon in all places.

It appears that sync.svg in the tree is still the old spinner, while it is correct in menuPanel.svg. I'm not sure if simply pulling the svg from menuPanel.svg and putting it in sync.svg is enough (and TBH, I'm not sure why menuPanel.svg isn't used in all cases.

Note also that http://searchfox.org/mozilla-central/source/browser/themes/shared/browser.inc.css#120 appears to imply sync.svg is used in the new "page action" menu, but I don't see it there in practice, so I'm not sure what's going on there.

Updated

3 months ago
Whiteboard: [fxsync] [photon-visual] → [fxsync] [photon-visual] [triage]
(Assignee)

Comment 1

3 months ago
> Note also that http://searchfox.org/mozilla-central/source/browser/themes/shared/browser.inc.css#120 appears to imply sync.svg is used in the new "page action" menu, but I don't see it there in practice, so I'm not sure what's going on there.

This is shown when the account is unverified or unconfigured: http://i.imgur.com/3btYUMl.png
(Reporter)

Comment 2

3 months ago
(In reply to Edouard Oger [:eoger] from comment #1)
> This is shown when the account is unverified or unconfigured:
> http://i.imgur.com/3btYUMl.png

Ah, thanks - that seems correct in that context. So I expect we want a new SVG for "synced tabs" rather than adjusting the existing sync.svg.
Comment hidden (mozreview-request)
(Assignee)

Comment 4

2 months ago
Created attachment 8875373 [details]
screenshots.zip
Assignee: nobody → eoger
Status: NEW → ASSIGNED
(Assignee)

Updated

2 months ago
Priority: -- → P1

Updated

2 months ago
Flags: qe-verify?
Whiteboard: [fxsync] [photon-visual] [triage] → [fxsync] [photon-visual]
(Reporter)

Comment 5

2 months ago
Comment on attachment 8875371 [details]
Bug 1369582 - Use dedicated synced tabs icon.

Dao, are you able to review this?
Attachment #8875371 - Flags: review?(markh) → review?(dao+bmo)

Comment 6

2 months ago
mozreview-review
Comment on attachment 8875371 [details]
Bug 1369582 - Use dedicated synced tabs icon.

https://reviewboard.mozilla.org/r/146802/#review151212
Attachment #8875371 - Flags: review?(dao+bmo) → review+

Comment 7

2 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5719ed999b40
Use dedicated synced tabs icon. r=dao

Comment 8

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5719ed999b40
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox-esr52: --- → unaffected

Updated

2 months ago
Iteration: --- → 55.7 - Jun 12
I have reproduce this bug with Nightly 55.0a1 (2017-06-01) in Windows 10 (64-bit).

This bug's fix is verified with latest Nightly 55.0a1 (64-bit).
 
Build ID   :    20170609030207
User Agent :	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170607]

Updated

a month ago
Flags: qe-verify? → qe-verify+
QA Contact: brindusa.tot
QA Contact: brindusa.tot → ovidiu.boca

Comment 10

14 hours ago
I verified this issue on Mac Os X 10.12, Mac OS 10.10, Windows 10, Windows 7 and Ubuntu 16.04 with FF Nightly 57.0a1(2017-08-16) and I can confirm the fix. I will mark this as verified fixed.
Status: RESOLVED → VERIFIED
status-firefox57: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.