Explicitly show the row / column in grid cell infobar

RESOLVED FIXED in Firefox 55

Status

enhancement
P3
normal
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: micah, Assigned: micah)

Tracking

(Blocks 1 bug)

unspecified
Firefox 55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We need to be clear about the row / column of a grid cell in the infobar. Instead of just displaying the row/ column numbers, we will show : `Row: ${rowNumber} / Column: ${colNumber}`
(Assignee)

Updated

2 years ago
Assignee: nobody → tigleym
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

2 years ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e9c3d9dd68e
Explicitly identify the row and columns in cell infobar. r=gl

Comment 4

2 years ago
mozreview-review
Comment on attachment 8874073 [details]
Bug 1369585 - Explicitly identify the row and columns in cell infobar.

https://reviewboard.mozilla.org/r/145536/#review149526
Attachment #8874073 - Flags: review?(gl) → review+
https://hg.mozilla.org/mozilla-central/rev/5e9c3d9dd68e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 6

2 years ago
> +layout.rowColumnPositions=Row %S \/ Column %S

This change is causing an error on the L10n dashboard:

"unknown escape sequence, \/ at line 48, column 34 for layout.rowColumnPositions"

How about using either only / or a dash here, or perhaps "Row %S, Column %S" to match a nearly similar string (console.properties:errLineCol)?
Flags: needinfo?(tigleym)
Flags: needinfo?(gl)

Comment 7

2 years ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ee2e37e9452
Remove L10n unknown escape sequence for layout.rowColumnPositions. r=me
Landed a fix.
Flags: needinfo?(tigleym)
Flags: needinfo?(gl)
(In reply to Gabriel [:gl] (ΦωΦ) from comment #8)
> Landed a fix.

Thanks!

Updated

10 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.