1369658 - Remove support for running subconfigures in parallel

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

Bug 1358023 and bug 1363992 removed the last uses of subconfigure other than js/src. We don't need all the machinery to run subconfigures in parallel anymore.

Further simplifications can probably be done, but let's keep things simple for now.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1369658 - Remove support for running subconfigures in parallel.

Bug 1358023 and bug 1363992 removed the last uses of subconfigure other
than js/src. We don't need all the machinery to run subconfigures in
parallel anymore.

Review commit: https://reviewboard.mozilla.org/r/145160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145160/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1369658 - Print out subconfigure output while it runs.

Now that subconfigure don't run in parallel, we don't need to care that
their output can be interleaved, so print it out while the subconfigure
executes.

Review commit: https://reviewboard.mozilla.org/r/145162/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145162/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8873751 [details]
Bug 1369658 - Remove support for running subconfigures in parallel.

https://reviewboard.mozilla.org/r/145160/#review149266

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8873752 [details]
Bug 1369658 - Print out subconfigure output while it runs.

https://reviewboard.mozilla.org/r/145162/#review149270

::: build/subconfigure.py:249
(Diff revision 1)
> +    proc = subprocess.Popen(*args, stdout=subprocess.PIPE,
> +                            stderr=subprocess.STDOUT, **kwargs)
> +    while True:
> +        line = proc.stdout.readline()

There /may/ be a buffering issue lingering in here somewhere on some platforms. But this is still better than it was before, so it isn't a big deal if there is.

::: build/subconfigure.py:255
(Diff revision 1)
> +        print prefix_lines(line.rstrip(), prefix)
> +        sys.stdout.flush()

One thing I've started doing for scripts that will always be executed by other scripts and won't cause problems if buffering is enabled since stdout goes to a pipe is to unbuffer stdout. `sys.stdout = os.fdopen(sys.stdout.fileno(), 'w', 1)`. You typically do that in __main__ or the entry point to the script.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a784646bf7be
Remove support for running subconfigures in parallel. r=gps
https://hg.mozilla.org/integration/autoland/rev/372bdca82f66
Print out subconfigure output while it runs. r=gps

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a784646bf7be
https://hg.mozilla.org/mozilla-central/rev/372bdca82f66