The lock and header url in the site identity subview are not on the same line

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Site Identity and Permission Panels
P1
normal
VERIFIED FIXED
6 months ago
6 months ago

People

(Reporter: johannh, Assigned: mikedeboer)

Tracking

({regression})

unspecified
Firefox 55
regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
See mozscreenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=edffa38ec0c515198f360f23d286290cb5081996&newProject=mozilla-central&newRev=cac2fd43de81d44b36396704220996b0c4a39f1a&filter=subview

Pushlog:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=edffa38ec0c515198f360f23d286290cb5081996&tochange=cac2fd43de81d44b36396704220996b0c4a39f1a

Mike mentioned he might know what caused this or how to fix it. Thanks for jumping in!
(Reporter)

Updated

6 months ago
status-firefox54: --- → unaffected
status-firefox55: --- → affected
Priority: -- → P1
Gijs, why was the change from

`panelview:not([title]) > .panel-header` to `panelview[mainView] > .panel-header` necessary again? This rule change in browser.css causes the header to be shown in all panelmultiviews, not just the photon one. :(
Blocks: 1354155
Flags: needinfo?(gijskruitbosch+bugs)
Comment hidden (mozreview-request)

Comment 3

6 months ago
(In reply to Mike de Boer [:mikedeboer] from comment #1)
> Gijs, why was the change from
> 
> `panelview:not([title]) > .panel-header` to `panelview[mainView] >
> .panel-header` necessary again? This rule change in browser.css causes the
> header to be shown in all panelmultiviews, not just the photon one. :(

Because otherwise the title is visible when a view with a title (such as the library view) is displayed as a main view (ie when displayed using the library button in the toolbar).
Flags: needinfo?(gijskruitbosch+bugs)

Comment 4

6 months ago
mozreview-review
Comment on attachment 8873766 [details]
Bug 1369659 - Make sure to hide the panelview header in non-photon panels, because it breaks their layout.

https://reviewboard.mozilla.org/r/145178/#review149146

Tentative r=me... can we also fix this by re-adding a :not([title]) selector in addition to the panelview[mainview] one (checking carefully that the library panel still works correctly when first opened as a subview in the main photon panel (which will cause the title attribute to get set based on its anchor there), and then as a 'standalone' panel)? If so, I would prefer that, because I imagine we want to eventually switch all the panelmultiviews to photon ones, and then get rid of the 'photon' in the name, at which point we'd have to fix this again...
Attachment #8873766 - Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (mozreview-request)

Comment 6

6 months ago
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb5fc68d7f71
Make sure to hide the panelview header in non-photon panels, because it breaks their layout. r=Gijs

Comment 7

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bb5fc68d7f71
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Reporter)

Comment 8

6 months ago
Looks fixed, thank you!

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=c67d811399a1408dd4c77a92584ecf480e3c972b&newProject=mozilla-central&newRev=43039280fe464869428f03b047bb7c762784f44b&filter=controlCenter
Status: RESOLVED → VERIFIED
status-firefox53: --- → unaffected
status-firefox-esr52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.