Closed Bug 1369673 Opened 7 years ago Closed 7 years ago

remove flag localeSwitchingIsEnabled from GeckoPreferences

Categories

(GeckoView :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox56 verified)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- verified

People

(Reporter: mail, Unassigned)

References

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170524180630

Steps to reproduce:

This is a flow-up bug for https://bugzilla.mozilla.org/show_bug.cgi?id=1217675
removing the flag and related logic, is this all?
Flags: needinfo?(nalexander)
Attachment #8873788 - Flags: review?(nalexander)
Depends on: 1217675
Comment on attachment 8873788 [details] [diff] [review]
1369673_friedger.patch

Review of attachment 8873788 [details] [diff] [review]:
-----------------------------------------------------------------

You've removed the last reference to `BrowserLocaleManager.isEnabled()`, so that can go: http://searchfox.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserLocaleManager.java#83.  That's the last reference to MOZ_LOCALE_SWITCHER, too, so _all_ of http://searchfox.org/mozilla-central/search?q=MOZ_LOCALE_SWITCHER&path= can go.

Good start!
Attachment #8873788 - Flags: review?(nalexander) → review-
Attachment #8875645 - Flags: review?(nalexander)
Comment on attachment 8875645 [details] [diff] [review]
1369673_friedger2.patch

Review of attachment 8875645 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like mobile/android/thirdparty/com/leanplum/Leanplum.java slipped into this patch; I saw you pushed it onto the blocking ticket's patch sequence, which this already depends on, so just make sure that it lands there and not in this one.

Thanks, friedger!
Attachment #8875645 - Flags: review?(nalexander) → review+
Flags: needinfo?(nalexander)
I have squashed the commits and send a review. How can I obsolete the two other attachments?
Flags: needinfo?(nalexander)
Comment on attachment 8877552 [details]
Bug 1369673 - remove flag localeSwitchingIsEnabled from GeckoPreferences

https://reviewboard.mozilla.org/r/148984/#review153508
Attachment #8877552 - Flags: review?(nalexander) → review+
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2fa8879d184
remove flag localeSwitchingIsEnabled from GeckoPreferences r=nalexander
(In reply to friedger from comment #6)
> I have squashed the commits and send a review. How can I obsolete the two
> other attachments?

No need, they can just hang out.  I r+ed and have triggered landing the commits.

sorina: could I get a manual test (after this makes it to Nightly) that local switching is still functioning?  Just a smoke test that we're able to switch from locale A to locale B using the Gecko preferences chooser.  Thanks!  (I flagged you since I see you doing QA on the bookmark management Fennec feature; please redirect if you're not the right person to do this.)
Flags: needinfo?(nalexander) → needinfo?(sorina.florean)
(In reply to Nick Alexander :nalexander from comment #9)
> (In reply to friedger from comment #6)
> > I have squashed the commits and send a review. How can I obsolete the two
> > other attachments?
> 
> No need, they can just hang out.  I r+ed and have triggered landing the
> commits.
> 
> sorina: could I get a manual test (after this makes it to Nightly) that
> local switching is still functioning?  Just a smoke test that we're able to
> switch from locale A to locale B using the Gecko preferences chooser. 
> Thanks!  (I flagged you since I see you doing QA on the bookmark management
> Fennec feature; please redirect if you're not the right person to do this.)

Sure, I will keep my needinfo to test this. And yes, I am the QA of Fennec - Bookmark Management feature and if there is anything to test/investigate please needinfo me. Thanks!
https://hg.mozilla.org/mozilla-central/rev/e2fa8879d184
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Tested with Asus ZenPad 8 (Android 6.0.1) on latest Nightly Build 56.0a1 from 2017/06/20. 
I confirm that is working as expected, switching from locale A to locale B and locale C and so on, is done without issues.
Flags: needinfo?(sorina.florean)
(In reply to Sorina Florean [:sorina] from comment #12)
> Tested with Asus ZenPad 8 (Android 6.0.1) on latest Nightly Build 56.0a1
> from 2017/06/20. 
> I confirm that is working as expected, switching from locale A to locale B
> and locale C and so on, is done without issues.

Many thanks, Sorina!
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 56 → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: