Closed
Bug 1369684
Opened 5 years ago
Closed 5 years ago
[Schema change request] Please help setup a new key in Switchboard.
Categories
(Cloud Services :: Operations: Kinto, task)
Cloud Services
Operations: Kinto
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cnevinchen, Unassigned)
References
Details
Attachments
(1 file)
880.16 KB,
image/png
|
Details |
Please help add a new key "region" in buckets/fennec/collections/experiments/ It should be a list like ["DE", "US" , "TW"] ?
Comment 1•5 years ago
|
||
For this we need to edit the JSON schema of the fennec/experiments collection: * Name: regions * This should be a new key in the "match" object. * The type should be a list of strings (Does the admin interface support this?) * Description: Compared with GeoIP lookup * Optional
Reporter | ||
Comment 2•5 years ago
|
||
Sorry for the rush. This is kind of urgent cause we are targeting release 55. Please help me if possible. Thanks!
Flags: needinfo?(rhubscher)
Flags: needinfo?(jthomas)
Comment 3•5 years ago
|
||
Something like that should do it: "regions": { "type": "array", "title": "Regions", "description": "Compared with GeoIP lookup.", "uniqueItems": true, "default": [], "items": { "title": "Regions", "description": "Similar to a GeoIP lookup", "type": "string", "minLength": 0, "default": "" } }
Updated•5 years ago
|
Flags: needinfo?(rhubscher)
Reporter | ||
Comment 4•5 years ago
|
||
Hi Rémy Thanks a lot! Is there anything I should do before I can use it in Kinto staging/procution?
Flags: needinfo?(rhubscher)
Comment 5•5 years ago
|
||
Nevin can you file a PR with your changes there? https://github.com/mozilla-services/switchboard-experiments-kinto/blob/master/kinto-bootstrap/config.json I will then be able to try it on kinto-ota. Then as soon as Jason wakes up we will be able to configure it in stage and production.
Flags: needinfo?(rhubscher)
Reporter | ||
Comment 6•5 years ago
|
||
Hi Rémy, Jason Please help verify : https://github.com/mozilla-services/switchboard-experiments-kinto/pull/5 Thank you!
Flags: needinfo?(rhubscher)
Comment 7•5 years ago
|
||
I merge the changes: https://github.com/mozilla-services/switchboard-experiments-kinto/pull/5
Flags: needinfo?(rhubscher)
Comment 8•5 years ago
|
||
This should have been inside the "match" object?
Comment 9•5 years ago
|
||
As you wish.
Comment 10•5 years ago
|
||
We have updated the schema in stage with sebastian review. Could you make sure everything works as expected on your end?
Flags: needinfo?(jthomas) → needinfo?(cnevinchen)
Reporter | ||
Comment 11•5 years ago
|
||
Hi Sebastian Could you please add "US" to regions for leanplum-start experiment? thank you!
Flags: needinfo?(cnevinchen) → needinfo?(s.kaspari)
Reporter | ||
Comment 12•5 years ago
|
||
Reporter | ||
Comment 13•5 years ago
|
||
Sorry I don't see them. Coul you please help me check what's going on?
Flags: needinfo?(rhubscher)
Comment 14•5 years ago
|
||
Nevin do you still have question about the new review feature ? What is the status of the rollout to production?
Flags: needinfo?(rhubscher)
Comment 15•5 years ago
|
||
I tested the schema change on staging today. LGTM. Please deploy to production. :)
Flags: needinfo?(s.kaspari)
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment 16•5 years ago
|
||
:sebastian can you mark it as verified to sign-off that everything is good on you side?
You need to log in
before you can comment on or make changes to this bug.
Description
•