1369684 - [Schema change request] Please help setup a new key in Switchboard.

Status: RESOLVED FIXED

(Cloud Services :: Operations: Kinto, task)

Description

[Nevin Chen(Not active on Bugzilla)]

Please help add a new key "region" in buckets/fennec/collections/experiments/ 
It should be a list like ["DE", "US" , "TW"] ?

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

For this we need to edit the JSON schema of the fennec/experiments collection:
* Name: regions
* This should be a new key in the "match" object.
* The type should be a list of strings (Does the admin interface support this?)
* Description: Compared with GeoIP lookup
* Optional

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Sorry for the rush.
This is kind of urgent cause we are targeting release 55.
Please help me if possible. Thanks!

Comment 3

[Rémy Hubscher (:natim)]

Something like that should do it:

"regions": {
  "type": "array",
  "title": "Regions",
  "description": "Compared with GeoIP lookup.",
  "uniqueItems": true,
  "default": [],
  "items": {
    "title": "Regions",
    "description": "Similar to a GeoIP lookup",
    "type": "string",
    "minLength": 0,
    "default": ""
  }
}

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Hi Rémy
Thanks a lot! 
Is there anything I should do before I can use it in Kinto staging/procution?

Comment 5

[Rémy Hubscher (:natim)]

Nevin can you file a PR with your changes there? https://github.com/mozilla-services/switchboard-experiments-kinto/blob/master/kinto-bootstrap/config.json

I will then be able to try it on kinto-ota.
Then as soon as Jason wakes up we will be able to configure it in stage and production.

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Hi Rémy, Jason

Please help verify : https://github.com/mozilla-services/switchboard-experiments-kinto/pull/5
Thank you!

Comment 7

[Rémy Hubscher (:natim)]

I merge the changes: https://github.com/mozilla-services/switchboard-experiments-kinto/pull/5

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

This should have been inside the "match" object?

Comment 9

[Rémy Hubscher (:natim)]

As you wish.

Comment 10

[Rémy Hubscher (:natim)]

We have updated the schema in stage with sebastian review. Could you make sure everything works as expected on your end?

Comment 11

[Nevin Chen(Not active on Bugzilla)]

Hi Sebastian
Could you please add "US" to regions for leanplum-start experiment?
thank you!

Comment 12

[Nevin Chen(Not active on Bugzilla)]

Attachment: Screenshot 2017-06-04 10.09.49.png

Comment 13

[Nevin Chen(Not active on Bugzilla)]

Sorry I don't see them. Coul you please help me check what's going on?

Comment 14

[Rémy Hubscher (:natim)]

Nevin do you still have question about the new review feature ? What is the status of the rollout to production?

Comment 15

[Sebastian Kaspari (:sebastian; :pocmo)]

I tested the schema change on staging today. LGTM. Please deploy to production. :)

Comment 16

[Rémy Hubscher (:natim)]

:sebastian can you mark it as verified to sign-off that everything is good on you side?