[Schema change request] Please help setup a new key in Switchboard.

RESOLVED FIXED

Status

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: cnevinchen, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Please help add a new key "region" in buckets/fennec/collections/experiments/ 
It should be a list like ["DE", "US" , "TW"] ?
For this we need to edit the JSON schema of the fennec/experiments collection:
* Name: regions
* This should be a new key in the "match" object.
* The type should be a list of strings (Does the admin interface support this?)
* Description: Compared with GeoIP lookup
* Optional
(Reporter)

Comment 2

a year ago
Sorry for the rush.
This is kind of urgent cause we are targeting release 55.
Please help me if possible. Thanks!
Flags: needinfo?(rhubscher)
Flags: needinfo?(jthomas)
Something like that should do it:

"regions": {
  "type": "array",
  "title": "Regions",
  "description": "Compared with GeoIP lookup.",
  "uniqueItems": true,
  "default": [],
  "items": {
    "title": "Regions",
    "description": "Similar to a GeoIP lookup",
    "type": "string",
    "minLength": 0,
    "default": ""
  }
}
Flags: needinfo?(rhubscher)
(Reporter)

Updated

a year ago
Blocks: 1369685
(Reporter)

Comment 4

a year ago
Hi Rémy
Thanks a lot! 
Is there anything I should do before I can use it in Kinto staging/procution?
Flags: needinfo?(rhubscher)
Nevin can you file a PR with your changes there? https://github.com/mozilla-services/switchboard-experiments-kinto/blob/master/kinto-bootstrap/config.json

I will then be able to try it on kinto-ota.
Then as soon as Jason wakes up we will be able to configure it in stage and production.
Flags: needinfo?(rhubscher)
(Reporter)

Comment 6

a year ago
Hi Rémy, Jason

Please help verify : https://github.com/mozilla-services/switchboard-experiments-kinto/pull/5
Thank you!
Flags: needinfo?(rhubscher)
This should have been inside the "match" object?
As you wish.
We have updated the schema in stage with sebastian review. Could you make sure everything works as expected on your end?
Flags: needinfo?(jthomas) → needinfo?(cnevinchen)
(Reporter)

Comment 11

a year ago
Hi Sebastian
Could you please add "US" to regions for leanplum-start experiment?
thank you!
Flags: needinfo?(cnevinchen) → needinfo?(s.kaspari)
(Reporter)

Comment 12

a year ago
Created attachment 8874181 [details]
Screenshot 2017-06-04 10.09.49.png
(Reporter)

Comment 13

a year ago
Sorry I don't see them. Coul you please help me check what's going on?
Flags: needinfo?(rhubscher)
Nevin do you still have question about the new review feature ? What is the status of the rollout to production?
Flags: needinfo?(rhubscher)
I tested the schema change on staging today. LGTM. Please deploy to production. :)
Flags: needinfo?(s.kaspari)
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
:sebastian can you mark it as verified to sign-off that everything is good on you side?
You need to log in before you can comment on or make changes to this bug.