1369695 - [TSF] TSFStaticSink shouldn't be initialized until first use

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement, P2)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1369695 Creating ITfInputProcessorProfiles and TSFStaticSink when they are used at first time

ITfProcessorProfiles are used by a debug method TSFTextStore::CurrentKeyboardLayoutHasIME() and TSFStaticSink (when it's initialized).  However, TSFStaticSink isn't necessary until when TSFTextStore needs to hack something for specific IME or notifying IMEHandler of active TIP change.  So, we can put off to create the instance of ITfInputProcessorProfiles and TSFStaticSink.

Review commit: https://reviewboard.mozilla.org/r/147146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147146/

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8875740 [details]
Bug 1369695 Creating ITfInputProcessorProfiles and TSFStaticSink when they are used at first time

https://reviewboard.mozilla.org/r/147146/#review151640

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd00685e1e66
Creating ITfInputProcessorProfiles and TSFStaticSink when they are used at first time r=m_kato

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd00685e1e66