Closed Bug 1369700 Opened 3 years ago Closed 3 years ago

Delay initialization of marionette.js until delayed startup and startup tests are finished

Categories

(Testing :: Marionette, enhancement, P1)

Version 3
enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Iteration:
55.7 - Jun 12
Tracking Status
firefox55 --- fixed

People

(Reporter: florian, Assigned: florian)

Details

(Whiteboard: [photon-performance][qa-])

Attachments

(1 file)

Currently marionette.js starts its initialization right after receiving the "sessionstore-windows-restored" notification.

This is unfortunate for the browser_startup.js browser chrome mochitest I added in bug 1358798, because it causes lots of marionette file to appear to be loaded before the browser is ready to handle user events.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 8873807 [details] [diff] [review]
Patch

Review of attachment 8873807 [details] [diff] [review]:
-----------------------------------------------------------------

r+wc: Please expand commit message with information about the motivation and reason behind this change.
Comment on attachment 8873807 [details] [diff] [review]
Patch

Review of attachment 8873807 [details] [diff] [review]:
-----------------------------------------------------------------

r+wc: Please expand commit message with information about the motivation and reason behind this change.
Attachment #8873807 - Flags: review?(ato) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3f93870b233
Delay initialization of marionette.js until delayed startup and startup tests are finished, r=ato.
Any particular reason why you used idleDispatch rather than explicitly observing the delayed startup finished notification?
Flags: needinfo?(florian)
https://hg.mozilla.org/mozilla-central/rev/a3f93870b233
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Iteration: --- → 55.7 - Jun 12
Priority: -- → P1
Whiteboard: [photon-performance]
(In reply to Dão Gottwald [::dao] from comment #5)
> Any particular reason why you used idleDispatch rather than explicitly
> observing the delayed startup finished notification?

There's a lot of stuff that observes the delayed-startup-notification, and cause jank at that point. We are really done with startup once the stuff started from that notification is finished, which means when the event queue is empty. That's what idleDispatch gives us.
Flags: needinfo?(florian)
(In reply to Florian Quèze [:florian] [:flo] from comment #7)
> (In reply to Dão Gottwald [::dao] from comment #5)
> > Any particular reason why you used idleDispatch rather than explicitly
> > observing the delayed startup finished notification?
> 
> There's a lot of stuff that observes the delayed-startup-notification,

I meant sessionstore-windows-restored.

Also, the code modified by this patch is already running off that notification.
Whiteboard: [photon-performance] → [photon-performance][qa-]
You need to log in before you can comment on or make changes to this bug.