Closed Bug 1369817 Opened 2 years ago Closed 2 years ago

Implement PWA orientation lock

Categories

(Firefox for Android :: General, enhancement)

enhancement
Not set

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed
firefox58 --- verified

People

(Reporter: snorp, Assigned: snorp)

References

(Blocks 1 open bug, )

Details

Attachments

(2 files)

This can be specified in the manifest, so we should enforce that in standalone PWA mode.
Attachment #8895027 - Flags: review?(dharvey) → review?(droeh)
Attachment #8895028 - Flags: review?(dharvey) → review?(droeh)
Comment on attachment 8895027 [details]
Bug 1369817 - Set screen orientation according to webapp manifest

https://reviewboard.mozilla.org/r/166158/#review174020

::: commit-message-f8eab:1
(Diff revision 1)
> +Bug 1369817 - Set screen orientation according to webapp manifest r=daleharvey

Update reviewer
Attachment #8895027 - Flags: review?(droeh) → review+
Comment on attachment 8895028 [details]
Bug 1369817 - Clean up webapp manifest handling

https://reviewboard.mozilla.org/r/166160/#review174024

::: commit-message-b0e57:1
(Diff revision 1)
> +Bug 1369817 - Clean up webapp manifest handling r=daleharvey

Update reviewer
Attachment #8895028 - Flags: review?(droeh) → review+
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d02042a6c56
Set screen orientation according to webapp manifest r=droeh
https://hg.mozilla.org/integration/mozilla-inbound/rev/61b906754ea7
Clean up webapp manifest handling r=droeh
Backed out bug 1369817, bug 1369815, bug 1389269 and bug 1126479 for crashing in mochitest-chrome-3's layout/style/test/chrome/test_stylesheet_clone_import_rule.html on debug:

bug 1369817
https://hg.mozilla.org/integration/mozilla-inbound/rev/4af3a98934c427226e095246a098008bc3474ee7
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bd81631bfad32fdc2fa46a8937d189caa21cb3d

bug 1369815
https://hg.mozilla.org/integration/mozilla-inbound/rev/7780a4af90284e7f812d44ec32adb68dcbcc94b1
https://hg.mozilla.org/integration/mozilla-inbound/rev/76f15802d69c2835eaa13e92df4bee34637f3b6c
https://hg.mozilla.org/integration/mozilla-inbound/rev/4871dc084c88feecdbabe1b3a9acdb5ffaa71a2b
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bbb1bd8335d0c49ac477e60e85a03029c8c6a17
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc485e4ba834888fb7f5bbb97f9a91c33c1a485

bug 1389269
https://hg.mozilla.org/integration/mozilla-inbound/rev/78e49684354331b02d3e425d2afcd757559bd7db

bug 1126479
https://hg.mozilla.org/integration/mozilla-inbound/rev/bec2a9eac2d9c7ec52543e5b77a6ee38c3f6879f
https://hg.mozilla.org/integration/mozilla-inbound/rev/337a6416a05bc3a9fac980eaa54084b78cd639b6

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4fb119706335b308f049949e5641565b035e4f80&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=123274657&repo=mozilla-inbound
Flags: needinfo?(snorp)
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8dc2f6c3a0ba
Set screen orientation according to webapp manifest r=droeh
https://hg.mozilla.org/integration/mozilla-inbound/rev/b896a49406de
Clean up webapp manifest handling r=droeh
https://hg.mozilla.org/mozilla-central/rev/8dc2f6c3a0ba
https://hg.mozilla.org/mozilla-central/rev/b896a49406de
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Verified this is implemented in Nightly 58 (2017-10-26).
Status: RESOLVED → VERIFIED
Assignee: nobody → snorp
You need to log in before you can comment on or make changes to this bug.