Closed Bug 1369866 Opened 3 years ago Closed 3 years ago

cross OSX builds always use dummy malloc linkage

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

Details

Attachments

(1 file)

The test in old-configure.in for MOZ_REPLACE_MALLOC_LINKAGE runs dyldinfo, which is a native tool on OSX. We have it in the cross toolchain as well, but as x86_64-apple-darwin11-dyldinfo. We should use the TOOLCHAIN_PREFIX here to make sure we get the same result as native builds.

Although this helps get consistency between cross and native builds, unfortunately it doesn't affect the performance discrepancy in bug 1338651.
Comment on attachment 8874017 [details]
Bug 1369866 - Use TOOLCHAIN_PREFIX when running dyldinfo;

https://reviewboard.mozilla.org/r/145468/#review149448
Attachment #8874017 - Flags: review?(ted) → review+
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bfb69fd3ed93
Use TOOLCHAIN_PREFIX when running dyldinfo; r=ted
https://hg.mozilla.org/mozilla-central/rev/bfb69fd3ed93
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.