Closed Bug 1369900 Opened 4 years ago Closed 4 years ago

[findbugs] Unnecessary boxing/unboxing in LocalBrowserDB tests

Categories

(Firefox for Android :: Data Providers, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: Grisha, Assigned: jwu)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Running findbugs locally produces a bunch of "DM_BOXED_PRIMITIVE_FOR_PARSING: Boxing/unboxing to parse a primitive" for the various Bookmarks Management tests in LocalBrowserDBTest.
Do you mind taking this on? Should be an easy tweak to the tests.
Flags: needinfo?(topwu.tw)
Assignee: nobody → topwu.tw
Flags: needinfo?(topwu.tw)
Comment on attachment 8877461 [details]
Bug 1369900 - Part 1: Use parseXXX instead of valueOf to prevent boxing/unboxing to parse a primitive.

https://reviewboard.mozilla.org/r/148890/#review153544
Attachment #8877461 - Flags: review?(gkruglov) → review+
Comment on attachment 8877462 [details]
Bug 1369900 - Part 2: Mark constant field with static keyword.

https://reviewboard.mozilla.org/r/148892/#review153546
Attachment #8877462 - Flags: review?(gkruglov) → review+
Pushed by gkruglov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50827c64885e
Part 1: Use parseXXX instead of valueOf to prevent boxing/unboxing to parse a primitive. r=Grisha
https://hg.mozilla.org/integration/autoland/rev/959fa5fe7bcf
Part 2: Mark constant field with static keyword. r=Grisha
https://hg.mozilla.org/mozilla-central/rev/50827c64885e
https://hg.mozilla.org/mozilla-central/rev/959fa5fe7bcf
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.