[findbugs] Unnecessary boxing/unboxing in LocalBrowserDB tests

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Grisha, Assigned: jwu)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Running findbugs locally produces a bunch of "DM_BOXED_PRIMITIVE_FOR_PARSING: Boxing/unboxing to parse a primitive" for the various Bookmarks Management tests in LocalBrowserDBTest.
(Reporter)

Comment 1

a year ago
Do you mind taking this on? Should be an easy tweak to the tests.
Flags: needinfo?(topwu.tw)
(Assignee)

Updated

a year ago
Assignee: nobody → topwu.tw
(Assignee)

Updated

a year ago
Flags: needinfo?(topwu.tw)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8877461 [details]
Bug 1369900 - Part 1: Use parseXXX instead of valueOf to prevent boxing/unboxing to parse a primitive.

https://reviewboard.mozilla.org/r/148890/#review153544
Attachment #8877461 - Flags: review?(gkruglov) → review+
(Reporter)

Comment 5

a year ago
mozreview-review
Comment on attachment 8877462 [details]
Bug 1369900 - Part 2: Mark constant field with static keyword.

https://reviewboard.mozilla.org/r/148892/#review153546
Attachment #8877462 - Flags: review?(gkruglov) → review+

Comment 6

a year ago
Pushed by gkruglov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50827c64885e
Part 1: Use parseXXX instead of valueOf to prevent boxing/unboxing to parse a primitive. r=Grisha
https://hg.mozilla.org/integration/autoland/rev/959fa5fe7bcf
Part 2: Mark constant field with static keyword. r=Grisha
https://hg.mozilla.org/mozilla-central/rev/50827c64885e
https://hg.mozilla.org/mozilla-central/rev/959fa5fe7bcf
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.