1369915 - Intermittent browser_UsageTelemetry_content_aboutHome.js | A promise chain failed to handle a rejection: this._window.document.body is null - rejection date: Fri Jun 02 2017 12:10:39 GMT-0700 (PDT)

Status: RESOLVED WORKSFORME

(Firefox :: General, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=104147388&repo=autoland

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-macosx64/autoland_yosemite_r7_test-mochitest-browser-chrome-2-bm136-tests1-macosx-build438.txt.gz

Comment 1

[Intermittent Failures Robot]

5 failures in 820 pushes (0.006 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 2
* try: 1
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* linux64: 2
* osx-10-10: 1
* linux32-nightly: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1369915&startday=2017-05-29&endday=2017-06-04&tree=all

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

36 failures since the 18th, this has increased in frequency and we should start looking into this.  It seems to fail on a mix of opt/debug, but not in e10s.


here is a recent linux64 asan log:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=109509561&lineNumber=3091

and the related information from the log:
[task 2017-06-23T10:02:25.527931Z] 10:02:25     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_content_aboutHome.js | browser.engagement.navigation.about_home must be recorded. - true == true - 
[task 2017-06-23T10:02:25.530015Z] 10:02:25     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_content_aboutHome.js | browser.engagement.navigation.about_home must contain the 'search_enter' key. - true == true - 
[task 2017-06-23T10:02:25.532029Z] 10:02:25     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_content_aboutHome.js | 1 - 1 == true - 
[task 2017-06-23T10:02:25.534117Z] 10:02:25     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_content_aboutHome.js | This search must only increment one entry in the scalar. - 1 == 1 - 
[task 2017-06-23T10:02:25.536830Z] 10:02:25     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_content_aboutHome.js | The histogram must contain other-MozSearch.abouthome. - true == true - 
[task 2017-06-23T10:02:25.540077Z] 10:02:25     INFO - TEST-PASS | browser/modules/test/browser/browser_UsageTelemetry_content_aboutHome.js | The key other-MozSearch.abouthome must contain 1. - 1 == 1 - 
[task 2017-06-23T10:02:25.541835Z] 10:02:25     INFO - Buffered messages finished
[task 2017-06-23T10:02:25.545338Z] 10:02:25     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_content_aboutHome.js | A promise chain failed to handle a rejection: this._window.document.body is null - rejection date: Fri Jun 23 2017 10:02:23 GMT+0000 (UTC) - stack: null - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 255
[task 2017-06-23T10:02:25.547153Z] 10:02:25     INFO - Stack trace:
[task 2017-06-23T10:02:25.548814Z] 10:02:25     INFO -     resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:255
[task 2017-06-23T10:02:25.551323Z] 10:02:25     INFO -     chrome://mochikit/content/browser-test.js:Tester_execTest/<:801
[task 2017-06-23T10:02:25.553341Z] 10:02:25     INFO -     Tester_execTest@chrome://mochikit/content/browser-test.js:774:9
[task 2017-06-23T10:02:25.558654Z] 10:02:25     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:686:7
[task 2017-06-23T10:02:25.560524Z] 10:02:25     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
[task 2017-06-23T10:02:25.562993Z] 10:02:25     INFO - Leaving test bound test_abouthome_simpleQuery
[task 2017-06-23T10:02:25.564906Z] 10:02:25     INFO - GECKO(1912) | MEMORY STAT | vsize 20973978MB | residentFast 709MB
[task 2017-06-23T10:02:25.568766Z] 10:02:25     INFO - TEST-OK | browser/modules/test/browser/browser_UsageTelemetry_content_aboutHome.js | took 3440ms


This test case is documented as being in the toolkit::telemetry component:
$ ./mach file-info bugzilla-component browser/modules/test/browser/browser_UsageTelemetry_content_aboutHome.js
Toolkit :: Telemetry
  browser/modules/test/browser/browser_UsageTelemetry_content_aboutHome.js

if that is wrong, please indicate so and help us annotate this properly.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

:gfritzsche, as the triage owner of toolkit::telemetry (and editor of this test a few times), I see that you changed the component of this bug- could you clarify?  If this is toolkit::telemetry can you help find someone on the telemetry team to look into this bug as it is failing quite often these days.

Comment 4

[Georg Fritzsche [:gfritzsche]]

This test is for Firefox code that uses Telemetry, it is not testing Telemetry itself.
We started the test, but don't own it.
I don't know where that annotation is from.

:past, do you know who would own this?

Comment 5

[Intermittent Failures Robot]

42 failures in 892 pushes (0.047 failures/push) were associated with this bug in the last 7 days. 

This is the #47 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 20
* autoland: 11
* try: 5
* mozilla-central: 5
* pine: 1

Platform breakdown:
* windows7-32-vm: 19
* linux64: 14
* linux32: 6
* osx-10-10: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1369915&startday=2017-06-19&endday=2017-06-25&tree=all

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

thanks or picking this up :past!

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

I don't have an owner yet, but someone should work on it soon.

Comment 8

[Intermittent Failures Robot]

17 failures in 718 pushes (0.024 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 9
* mozilla-inbound: 4
* try: 2
* mozilla-central: 2

Platform breakdown:
* windows7-32-vm: 7
* linux64: 4
* linux32: 3
* osx-10-10: 2
* linux64-ccov: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1369915&startday=2017-06-26&endday=2017-07-02&tree=all

Comment 9

[Intermittent Failures Robot]

18 failures in 656 pushes (0.027 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 9
* try: 3
* mozilla-inbound: 3
* pine: 1
* oak: 1
* mozilla-central: 1

Platform breakdown:
* windows7-32-vm: 7
* linux64: 6
* osx-cross: 3
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1369915&startday=2017-07-03&endday=2017-07-09&tree=all

Comment 10

[Intermittent Failures Robot]

39 failures in 720 pushes (0.054 failures/push) were associated with this bug in the last 7 days. 

This is the #33 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 17
* mozilla-inbound: 13
* mozilla-central: 5
* oak: 2
* try: 1
* pine: 1

Platform breakdown:
* windows7-32: 16
* windows7-32-vm: 9
* linux64: 9
* linux32: 4
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1369915&startday=2017-07-10&endday=2017-07-16&tree=all

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

seems that we have many more failures in the last week- a higher push rate could help contribute to that- :past, is this in a queue to pick up in the near future?

Comment 12

[Panos Astithas (he/him) [:past] (please ni?)]

Yes, it still is in our P1 list: https://wiki.mozilla.org/Firefox/Search#Releases
However, between other priorities and summer PTO it hasn't been picked up yet.

Comment 13

[Intermittent Failures Robot]

38 failures in 822 pushes (0.046 failures/push) were associated with this bug in the last 7 days. 

This is the #49 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 14
* mozilla-inbound: 12
* try: 10
* mozilla-central: 2

Platform breakdown:
* windows7-32: 25
* linux64: 9
* osx-10-10: 2
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1369915&startday=2017-07-17&endday=2017-07-23&tree=all

Comment 14

[Marco Bonardo [:mak]]

The current error I see is 

JavaScript error: resource://onboarding/onboarding.js, line 764: TypeError: doc.head is null

I don't think we have onboarding on about:home, so I suspect this comes from browser_UsageTelemetry_content.js that load about:newTab.
Looks like onboarding is waiting for the load listener in _loadCSS, then it proceeds. By the time we reach _loadJS the tab may have been closed.

:rexboy, may you look into this problem with onboarding?

Comment 15

[Marco Bonardo [:mak]]

Note that the most updated error points to line 868 that is indeed the doc.head usage in _loadJS

Comment 16

[KM Lee [:rexboy] (inactivate after Sep. 22)]

We do load onboarding in both about:home and about:newtab.
From comment 14, that may because we postponed the loading process to idle time after window.onload, but I need to do some investigating first.

Comment 17

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Bug 1369915 - Remote try

Review commit: https://reviewboard.mozilla.org/r/161388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161388/

Comment 18

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8890269 [details]
Bug 1369915 - Remote try

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161388/diff/1-2/

Comment 19

[Intermittent Failures Robot]

60 failures in 1008 pushes (0.06 failures/push) were associated with this bug in the last 7 days. 

This is the #40 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 35
* mozilla-inbound: 19
* mozilla-central: 4
* try: 2

Platform breakdown:
* windows7-32: 55
* osx-10-10: 4
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1369915&startday=2017-07-24&endday=2017-07-30&tree=all

Comment 20

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Added some logs to inspect, but I can't reproducible on try yet.. still trying.

Comment 21

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8890269 [details]
Bug 1369915 - Remote try

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161388/diff/2-3/

Comment 22

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Seems it's not easy to reproduce for me -- and at the same time the latest orange count has dropped down to nearly just 1%.
I'll continue to investigate by running try. But if it can't be reproduced for a while maybe we can just close it.

Comment 23

[KM Lee [:rexboy] (inactivate after Sep. 22)]

https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1369915&startday=2017-07-28&endday=2017-08-08&tree=all

There has been no failures for a week. Let's assume the cause has been resolved somewhere and close it.

Comment 24

[Francis Lee [:frlee]]

remove whiteboard tag due to its WORKSFORME

Comment 25

[Joel Maher ( :jmaher ) (UTC -8)]

the fix is that we disabled the non-e10s testing.