APZC tree printing is broken

RESOLVED FIXED in Firefox 55

Status

()

defect
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: botond, Assigned: botond)

Tracking

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

Assignee

Description

2 years ago
STR:
  1. Run a debug build of Nightly
  2. Enable the pref "apz.printtree"

Expected results:

  Readable dumps of the APZC tree are printed to stderr.

Actual results:

  The lines of the dumps have an unreasonable amount of space
  in front of them. The amount of space increases over time.

Probably a bug similar to one we had before where we are increasing the indentation level on the tree logger, and not decreasing it.
Priority: -- → P3
Whiteboard: [gfx-noted]
Assignee

Comment 1

2 years ago
This was regressed in bug 1227233.

TreeAutoIndent was given a copy constructor which delegates to the regular constructor, and also increases the indent in the constructor body. As a result, every time a TreeAutoIndent object is copied, the indent is increased twice: once in the body of the regular constructor, and once in the body of the copy constructor.
Depends on: 1227233

Comment 3

2 years ago
mozreview-review
Comment on attachment 8874481 [details]
Bug 1369929 - Do not increase the indent twice in the TreeAutoIndent copy constructor.

https://reviewboard.mozilla.org/r/145846/#review149794
Attachment #8874481 - Flags: review?(bugmail) → review+

Comment 4

2 years ago
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd1ece6b6180
Do not increase the indent twice in the TreeAutoIndent copy constructor. r=kats

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dd1ece6b6180
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.