Status

()

P3
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(3 attachments)

Update to the current master of aom. This fixes a build issue on win64.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee: nobody → giles

Comment 4

2 years ago
mozreview-review
Comment on attachment 8874069 [details]
Bug 1369950 - Update av1 mimetype when vendoring.

https://reviewboard.mozilla.org/r/145524/#review149512

LGTM

::: python/mozbuild/mozbuild/vendor_aom.py:103
(Diff revision 1)
> +        filename = mozpath.join(self.topsrcdir,
> +                'dom/media/platforms/agnostic/AOMDecoder.cpp')
> +        with open(filename) as f:
> +            source = f.read()
> +
> +        # Substitue the new revision in lines like

'Substitue' -> 'Substitute'
Attachment #8874069 - Flags: review?(gsquelart) → review+

Comment 5

2 years ago
mozreview-review
Comment on attachment 8874070 [details]
Bug 1369950 - Remove aom_codec_stream_info_t sz field references.

https://reviewboard.mozilla.org/r/145526/#review149514
Attachment #8874070 - Flags: review?(gsquelart) → review+

Comment 6

2 years ago
mozreview-review
Comment on attachment 8874071 [details]
Bug 1369950 - Update aom.

https://reviewboard.mozilla.org/r/145528/#review149516
Attachment #8874071 - Flags: review?(gsquelart) → review+
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 10

2 years ago
mozreview-review-reply
Comment on attachment 8874069 [details]
Bug 1369950 - Update av1 mimetype when vendoring.

https://reviewboard.mozilla.org/r/145524/#review149512

> 'Substitue' -> 'Substitute'

Thanks!

Comment 11

2 years ago
mozreview-review
Comment on attachment 8874069 [details]
Bug 1369950 - Update av1 mimetype when vendoring.

https://reviewboard.mozilla.org/r/145524/#review149846

::: python/mozbuild/mozbuild/vendor_aom.py:106
(Diff revision 2)
> +            source = f.read()
> +
> +        # Substitute the new revision in lines like
> +        #   version.AppendLiteral("abcdef0124");
> +        prefix = 'version.AppendLiteral'
> +        new_source = re.sub(prefix + '\("[a-f0-9]+"\);',

Maybe make this match the exact number of characters in the commit hash, rather than just `+`?
Attachment #8874069 - Flags: review?(nfroyd) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 15

2 years ago
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e709485195e6
Update av1 mimetype when vendoring. r=froydnj,gerald
https://hg.mozilla.org/integration/autoland/rev/67152605b367
Remove aom_codec_stream_info_t sz field references. r=gerald
https://hg.mozilla.org/integration/autoland/rev/12d353fc5067
Update aom. r=gerald
https://hg.mozilla.org/mozilla-central/rev/e709485195e6
https://hg.mozilla.org/mozilla-central/rev/67152605b367
https://hg.mozilla.org/mozilla-central/rev/12d353fc5067
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.