Closed Bug 1369959 Opened 7 years ago Closed 6 years ago

Intermittent browser/base/content/test/performance/browser_appmenu_reflows.js | unexpected uninterruptible reflow

Categories

(Firefox :: Menus, defect)

defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Whiteboard: [stockwell unknown])

we have 35 failures today on this bug, lets look into this
Whiteboard: [stockwell needswork]
Component: General → Menus
osx debug seems to be the primary failure today- let me see if I can find the root cause.  As this is a fairly new test (landed 21 days ago, oddly when this bug was opened), I will ask the original author (:mconley) to shed some light here or help find someone who might be have to help make this test great again!
Flags: needinfo?(mconley)
oh, looks like this was fixed by backing out the offender (bug 1369729):
https://hg.mozilla.org/integration/autoland/rev/391c04c22f939624a30969f1a43cc7e94ad62920

lets not worry for now
Flags: needinfo?(mconley)
Whiteboard: [stockwell needswork] → [stockwell fixed:backout]
Looks like this is happening with regularity again.
Flags: needinfo?(mconley)
Frequency of this one seems to have gone way down since bug 1363361 landed, fwiw. We disable that test for debug buidls - we might want to disable this for ASAN builds too.
Flags: needinfo?(mconley)
Keywords: leave-open
See Also: → 1363361, 1382809
Whiteboard: [stockwell fixed:backout] → [stockwell disabled]
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70c553a3e2da
Skip test browser_appmenu_reflows.js on more platforms, for frequent intermittent failures; r=me,test-only
This has failed 32 times in the last 7 days. It started spiking from 25 January. It failed on Windows 10, Windows 7, OSX 10, linux64-nightly, windows7-32-nightly, windows10-64-nightly platforms, affecting pgo and opt build types. 
Failing tests: windows7-32/opt-test-verify-e, test-windows10-64/opt-test-verify, est-windows7-32-pgo/opt-test-verify-e.
These tests were failing on central, autoland and inbound repos.

Also this test was disabled in 31 Jul 2017 on asan and debug build types, and before that it was disabled on OSX and Windows debug  buld type. 
https://hg.mozilla.org/integration/mozilla-inbound/rev/70c553a3e2da


         --- a/browser/base/content/test/performance/browser.ini
         +++ b/browser/base/content/test/performance/browser.ini
         @@ -1,13 +1,13 @@
             [DEFAULT]
         support-files =
         head.js
        [browser_appmenu_reflows.js]
         -skip-if = (os == 'mac' || os == 'win') && debug # Bug 1382809
         +skip-if = asan || debug # Bug 1382809, bug 1369959
         [browser_startup.js]
         [browser_startup_content.js]

Link to a recent log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=158603801&line

Part of that log: 02:34:26     INFO -  	"SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59",
15183
02:34:26     INFO -  	""
15184
02:34:26     INFO -  ]' - true == true -
15185
02:34:26     INFO -  Buffered messages finished
15186
02:34:26    ERROR -  37 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_appmenu_reflows.js | unexpected uninterruptible reflow
15187
02:34:26     INFO -  [
15188
02:34:26     INFO -  	"descriptionHeightWorkaround@resource:///modules/PanelMultiView.jsm:929:21",
15189
02:34:26     INFO -  	"set current@resource:///modules/PanelMultiView.jsm:810:9",
15190
02:34:26     INFO -  	"hideAllViewsExcept@resource:///modules/PanelMultiView.jsm:336:5",
15191
02:34:26     INFO -  	"_cleanupTransitionPhase@resource:///modules/PanelMultiView.jsm:619:5",
15192
02:34:26     INFO -  	"async*_transitionViews@resource:///modules/PanelMultiView.jsm:594:11",
15193
02:34:26     INFO -  	"async*showSubView/this._currentShowPromise<@resource:///modules/PanelMultiView.jsm:429:15",
15194
02:34:26     INFO -  	"async*showSubView@resource:///modules/PanelMultiView.jsm:341:33",
15195
02:34:26     INFO -  	"value@resource:///modules/PanelMultiView.jsm:237:42",

This bug is related to 1382809.

ni :jaws could you please take a look?
Flags: needinfo?(jaws)
Whiteboard: [stockwell disabled] → [stockwell needswork]
Redirecting to Mike, who wrote the test.
Flags: needinfo?(jaws) → needinfo?(mconley)
I changed the output of the reflow tests in bug 1438233 to make it more usable. It's likely that this bug has multiple different failures reported as the same bug because the output shown in treeherder was unclear. I verified that all the failures reported  in comment 43 occurred before bug 1438233 landed. For future failures of this test, please file new bugs with a summary containing the new error reported by the test, and don't hesitate to cc mconley and me. Thanks!
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(mconley)
Resolution: --- → INCOMPLETE
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.