13700 - Warning: "overwriting current primary frame" at file nsFrameManager.cpp, line 273

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Akkana Peck]

As of this morning's build (9/13), I get lots of these on nearly every page I
load:
Warning: "overwriting current primary frame" at file nsFrameManager.cpp, line
273

Comment 1

[troy]

Akkana, you should know better than to submit a bug like this. There's no sample
URL or anything to reproduce the problem.

Comment 2

[Akkana Peck]

I didn't think it was necessary since I see it on every page I load, but okay,
here's the one I've been doing lately: run
apprunner "http://bugzilla.mozilla.org/showattachment.cgi?attach_id=1619"
and enjoy the 40 repetitions of this warning.

Comment 3

[troy]

Okay, so I'm not seeing it in my tree which means it must be a change sometime
between like 5PM yesterday and whenever you pulled

Comment 4

[Akkana Peck]

I pulled at around 11am 9/13.

Comment 5

[leger]

So is his Resolved now?

Comment 6

[troy]

No, I'm pulling and building to see if I can reproduce the problem

Comment 7

[troy]

So the reason I'm not seeing any of those annoying messages is that NS_WARNING
doesn't seem to do much of anything on Windows. It doesn't print to the console
anyway

I set a breakpoint and looked at it in the debugger. It's all the same case
where images aren't loading and we replace the image frame with the alternate
content instead.

The warning in SetPrimaryFrameFor() was really only needed in the very beginning
to make sure nothing silly was happening.

I'm removing the warning

Comment 8

[Chris Petersen]

Based on troy's comments, marking as verified fixed in the Sept 23rd build.