turn off more warnings in crashreporter code

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Crash Reporting
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: emk, Assigned: emk)

Tracking

unspecified
mozilla55
All
Windows
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
This is an MSVC counterpart of bug 1369788.

52:27.40 warning: toolkit/crashreporter/google-breakpad/src/processor/minidump.cc:3762 [C4334] '<<': 32 ビット シフトの 結果が暗黙的に 64 ビットに変換されました (64 ビット シフトに意図的に変換しようとしましたか?)
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/processor/postfix_evaluator-inl.h:305 [C4146] 符号付きの値を代入する変数は、符号付き型にキャストしなければなりません。
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/processor/stackwalker_mips.cc:60 [C4804] '>': 演算中の 'bool' 型の使用方法が安全ではありません
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/processor/stackwalker_mips.cc:68 [C4804] '>': 演算中の 'bool' 型の使用方法が安全ではありません
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/third_party/libdisasm/x86_disasm.c:38 [C4312] '型キャスト': 'long' からより大きいサイズの 'void *' へ変換します。
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/third_party/libdisasm/x86_disasm.c:56 [C4312] '型キャスト': 'long' からより大きいサイズの 'void *' へ変換します。
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/third_party/libdisasm/x86_disasm.c:62 [C4312] '型キャスト': 'long' からより大きいサイズの 'void *' へ変換します。
52:27.40 warning: toolkit/crashreporter/google-breakpad/src/third_party/libdisasm/x86_disasm.c:180 [C4312] '型キャスト': 'long' からより大きいサイズの 'void *' へ変換します。
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED

Comment 2

a year ago
mozreview-review
Comment on attachment 8874192 [details]
Bug 1370061 - turn off more warnings in crashreporter code. .mielczarek

https://reviewboard.mozilla.org/r/145620/#review149772
Attachment #8874192 - Flags: review?(ted) → review+

Comment 3

a year ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/20b0cc57dc92
turn off more warnings in crashreporter code. r=ted.mielczarek
https://hg.mozilla.org/mozilla-central/rev/20b0cc57dc92
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
and there is data to show a reduction in compiler warnings:
== Change summary for alert #7045 (as of June 05 2017 21:08 UTC) ==

Improvements:

  3%  compiler warnings summary windows2012-64 opt      247.00 -> 239.00
  3%  compiler warnings summary windows2012-64 debug    254.00 -> 246.00
  3%  compiler warnings summary windows2012-64 pgo      267.67 -> 259.42
  2%  compiler warnings summary windows2012-32 opt      220.00 -> 216.00
  2%  compiler warnings summary windows2012-32 debug    226.00 -> 222.00
  2%  compiler warnings summary windows2012-32-noopt debug 230.00 -> 226.00
  2%  compiler warnings summary windowsxp opt           220.00 -> 216.67
  2%  compiler warnings summary windows2012-32 pgo      237.25 -> 233.67

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7045
You need to log in before you can comment on or make changes to this bug.