1370083 - [Photon] (some?) panels have ~4px blank space at the bottom underneath the footer/content

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Sören Hentzschel]

Attachment: screenshot3.png

As you can see in the attached screenshot there is a gap on the footer of the history subview of the new library button.

Comment 1

[:Gijs (he/him)]

I've also noticed this in the pocket panel. I don't think it's related to the library specifically.

Comment 2

[Gary [:streetwolf52]]

Attachment: uBlock Origin add-on with extra space on menu.

The menu for uBlock Origin has extra space on the top and bottom (see arrows on screenshot). This only happens with Photon enabled. I contacted the developer and here is what he told me:

uBO embed its frame into the Firefox's-provided panel, and that panel has a padding style causing the issue (line 339 in panelUI.css):

/* START photonpanelview adjustments */

#appMenu-popup > .panel-arrowcontainer > .panel-arrowcontent {
  padding: 0;
  border-radius: 0;
}

photonpanelmultiview panelview {
  background: var(--arrowpanel-background);
  padding: 6px 0;
}

When commenting out the padding style above (the 6px one), it renders fine. The padding style above is in addition to the padding style seen in one of the ancestor element (line 328 in panelUI.css):

.cui-widget-panel > .panel-arrowcontainer > .panel-arrowcontent {
  padding: 4px 0;
}

Meaning the resulting padding is 10 pixels with Photon. I doubt this was meant to be this much. One of the two styles probably needs to be revised.

Comment 3

[Gary [:streetwolf52]]

Evidently the developer of uBO fixed the menu problem in his latest beta version.  He mentioned to me that he could fix it but thought that the real fix is for Mozilla to fix their code per the info above.

Comment 6

[Jonathan Kingston [:jkt] he/him]

As mentioned in Bug 1373661 I think it is the following:


In chrome://browser/skin/customizableui/panelUI.css#339

photonpanelmultiview panelview {
    background: var(--arrowpanel-background);
    padding: 6px 0;
}

Comment 7

[:Gijs (he/him)]

(In reply to Jonathan Kingston [:jkt] from comment #6)
> As mentioned in Bug 1373661 I think it is the following:
> 
> 
> In chrome://browser/skin/customizableui/panelUI.css#339
> 
> photonpanelmultiview panelview {
>     background: var(--arrowpanel-background);
>     padding: 6px 0;
> }

Yes, though it is not super straightforward to come up with a selector that does exactly the right thing here. This doesn't just affect add-on views, you also see this on views that have footers (like the history subview).

I think the padding might want to move to the .panel-subview-body, and we may want to reduce the bottom padding if there's a footer.

Comment 8

[:Gijs (he/him)]

The fourth patch in bug 1354159 looks set to fix this.

Comment 9

[:Gijs (he/him)]

Should be fixed on m-c as currently building, probably tomorrow's nightly.

Comment 10

[u554753]

Verified on Windows, Mac, and Ubuntu.