Closed Bug 1370102 Opened 3 years ago Closed 3 years ago

Make browser_console_dead_objects.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event

Categories

(DevTools :: Console, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Blocks: 1361461
Comment on attachment 8874247 [details] [diff] [review]
Make browser_console_dead_objects.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event

Review of attachment 8874247 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/webconsole/test/browser_console_dead_objects.js
@@ +31,5 @@
>      Services.prefs.setBoolPref("devtools.chrome.enabled", true);
>      yield loadTab(TEST_URI);
> +    let dwu = content.window.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
> +                            .getInterface(Components.interfaces.nsIDOMWindowUtils);
> +    let winID = dwu.outerWindowID;

Please use `tab.linkedBrowser.outerWindowID` for this, in case we want to support e10s mode in these tests at some point. Or the no-cpows-in-tests rule gets turned on for this directory.
Attachment #8874247 - Flags: review?(kmaglione+bmo) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd5d16e7085
Make browser_console_dead_objects.js correctly wait for the window to be destroyed instead of relying on the scheduling of the corresponding event; r=kmag
https://hg.mozilla.org/mozilla-central/rev/5dd5d16e7085
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.