All users were logged out of Bugzilla on October 13th, 2018

Add workaround for _LIBCPP_ALWAYS_INLINE to support NDK r12+ with clang

RESOLVED FIXED in Firefox 56

Status

RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: m_kato, Assigned: froydnj)

Tracking

55 Branch
mozilla56
Unspecified
Android

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Bug 1277619 adds a workaround for visibility when using clang on NDK.  When usign NDK r12+, it has _LIBCPP_ALWAYS_INLINE that has same problem.

_LIBCPP_ALWAYS_INLINE needs same workaround like _LIBCPP_INLINE_VISIBILITY
(Assignee)

Updated

a year ago
Assignee: nobody → nfroyd
(Assignee)

Comment 1

a year ago
Created attachment 8883093 [details] [diff] [review]
add workarounds for _LIBCPP_ALWAYS_INLINE bustedness

_LIBCPP_ALWAYS_INLINE and its EXCEPT_GCC49 counterpart are broken in the
same fashion as _LIBCPP_INLINE_VISIBILITY and can be fixed in exactly
the same way.
Attachment #8883093 - Flags: review?(cmanchester)
Attachment #8883093 - Flags: review?(cmanchester) → review+

Comment 2

a year ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/525cc3b789fc
add workarounds for _LIBCPP_ALWAYS_INLINE bustedness; r=chmanchester

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/525cc3b789fc
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.