1370144 - Push author tooltip is broken

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Dunno when it happened (something with switching to React, maybe?), but when you hover over a push author's email address, the tooltip that appears just says "View pushes by ". The code for this is at https://github.com/mozilla/treeherder/blob/be8c7be9ad3bf17541849dc8aaf5b051be0d0435/ui/js/directives/treeherder/resultsets.js#L50 and it should include the author's email address in the tooltip.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Ed, would you rather we fix this so the tooltip shows author email again, or just change it so it just says something like "View pushes by this user", since the email address is already in the push header?

Comment 2

[Ed Morley [:emorley]]

Yeah I think the email address in the tooltip is unnecessary, let's remove it :-)

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:authortooltip > mozilla:master

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8875088 [details] [review]
[treeherder] KWierso:authortooltip > mozilla:master

I removed all of the code other than pulling out the email address for use in the actual push header and changed the tooltip to be "View pushes by this user". I don't think this is used anywhere else where all of the other bits are actually useful. 

I haven't exhaustively searched more than trunk gecko repos to see if other repos actually provide the rest of the author information like the "First Last <email>" format it seems to be expecting (that format only seems to be used for the revision authors, but those are now handled in reactrevisions.something). Maybe git-based repos show push author's differently? Haven't checked. If I need to add the other lines back for something, let me know. :)

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8875088 [details] [review]
[treeherder] KWierso:authortooltip > mozilla:master

Left a comment on the PR :-)

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8875088 [details] [review]
[treeherder] KWierso:authortooltip > mozilla:master

I think the PR was correct as it was, for everything except for the now-defunct servo repo, which hasn't had a commit since December. Left a comment in the PR explaining things. :)

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8875088 [details] [review]
[treeherder] KWierso:authortooltip > mozilla:master

Left some comments :-)

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8875088 [details] [review]
[treeherder] KWierso:authortooltip > mozilla:master

Addressed some comments. :)

Comment 9

[Ed Morley [:emorley]]

Comment on attachment 8875088 [details] [review]
[treeherder] KWierso:authortooltip > mozilla:master

Almost there! Left a comment :-)

Comment 10

[Ed Morley [:emorley]]

Comment on attachment 8875088 [details] [review]
[treeherder] KWierso:authortooltip > mozilla:master

Nice! :-)

Comment 11

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/89e648b148f4dd639b4ba4e754fbbdc9b759771f
Bug 1370144 - Fix the Push author tooltip (#2541) r=emorley