Closed
Bug 1370155
Opened 7 years ago
Closed 7 years ago
Remove fullscreen mode in basic compositor video test
Categories
(Testing :: Talos, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: ethlin, Assigned: ethlin)
References
Details
Attachments
(1 file)
1.10 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
It looks like the fullscreen mode causes the intermittent problem, see bug 1192317. Other resolutions should be enough for now so I'll remove the fullscreen mode.
Assignee | ||
Comment 1•7 years ago
|
||
I sent a try push[1] and it looks like the intermittent problem doesn't happen. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=c72ed5ffa45e6dce14f1cc46f43eea14b4948d39
Attachment #8874344 -
Flags: review?(jmaher)
Comment 2•7 years ago
|
||
Comment on attachment 8874344 [details] [diff] [review] Remove fullscreen mode. Review of attachment 8874344 [details] [diff] [review]: ----------------------------------------------------------------- this is nice and simple!
Attachment #8874344 -
Flags: review?(jmaher) → review+
Pushed by ethlin@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cac26305ac53 Remove fullscreen mode in basic compositor video test to prevent intermittent problem. r=jmaher
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cac26305ac53
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 5•7 years ago
|
||
and we get improvements from this: == Change summary for alert #7056 (as of June 06 2017 01:57 UTC) == Improvements: 17% basic_compositor_video summary windows10-64 opt e10s 4.55 -> 3.79 14% basic_compositor_video summary windows7-32 opt e10s 4.29 -> 3.69 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7056
Comment 6•7 years ago
|
||
Another improvement on linux64: == Change summary for alert #7056 (as of June 06 2017 01:57 UTC) == Improvements: 28% basic_compositor_video summary linux64 opt e10s 5.15 -> 3.70 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7056
You need to log in
before you can comment on or make changes to this bug.
Description
•