Closed Bug 1370155 Opened 7 years ago Closed 7 years ago

Remove fullscreen mode in basic compositor video test

Categories

(Testing :: Talos, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ethlin, Assigned: ethlin)

References

Details

Attachments

(1 file)

It looks like the fullscreen mode causes the intermittent problem, see bug 1192317. Other resolutions should be enough for now so I'll remove the fullscreen mode.
I sent a try push[1] and it looks like the intermittent problem doesn't happen.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=c72ed5ffa45e6dce14f1cc46f43eea14b4948d39
Attachment #8874344 - Flags: review?(jmaher)
Comment on attachment 8874344 [details] [diff] [review]
Remove fullscreen mode.

Review of attachment 8874344 [details] [diff] [review]:
-----------------------------------------------------------------

this is nice and simple!
Attachment #8874344 - Flags: review?(jmaher) → review+
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cac26305ac53
Remove fullscreen mode in basic compositor video test to prevent intermittent problem. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/cac26305ac53
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1192317
and we get improvements from this:
== Change summary for alert #7056 (as of June 06 2017 01:57 UTC) ==

Improvements:

 17%  basic_compositor_video summary windows10-64 opt e10s     4.55 -> 3.79
 14%  basic_compositor_video summary windows7-32 opt e10s      4.29 -> 3.69

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7056
Another improvement on linux64:

== Change summary for alert #7056 (as of June 06 2017 01:57 UTC) ==

Improvements:

 28%  basic_compositor_video summary linux64 opt e10s     5.15 -> 3.70

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7056
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: