1370164 - Flushing may leave H264Converter in inconsistent state

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Jean-Yves Avenard [:jya]]

In the H264Converter, when we encounter a change of stream we flush then shutdown the current decoder.

However, if Flush is called right at that time, then the decoder may not be properly re-created as we have stored the new extradata before actually using.

So after the next Decode, the decoder will not be correctly recreated.

Comment 1

[Jean-Yves Avenard [:jya]]

My original analysis was incorrect.

The extradata fields are properly updated when they need to be so it's all fine there.

However, if H264Converter::Flush() is called in the middle of a configuration change, then the current decoder may be left in an inconsistent state (such as being called while a flush is currently going).
Also H264Converter::Flush should wait for any pending shutdown to complete before resolving its promise.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1370164: Properly handle flushing during ongoing operations.

Review commit: https://reviewboard.mozilla.org/r/145890/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145890/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8874523 [details]
Bug 1370164: Properly handle flushing during ongoing operations.

https://reviewboard.mozilla.org/r/145890/#review149986

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8874523 [details]
Bug 1370164: Properly handle flushing during ongoing operations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145890/diff/1-2/

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8874523 [details]
Bug 1370164: Properly handle flushing during ongoing operations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145890/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78dcfa118bdd
Properly handle flushing during ongoing operations. r=jwwang

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/78dcfa118bdd