1370210 - obj_propertyIsEnumerable calls non-inlined IsSymbolOrSymbolWrapper

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[André Bargull [:anba]]

obj_propertyIsEnumerable calls ValueToId, which in turn calls IsSymbolOrSymbolWrapper, but IsSymbolOrSymbolWrapper isn't an inline function, maybe it should be?

Comment 1

[Jan de Mooij [:jandem]]

Good find!

I think it would also be nice to instrument ValueToId to see what the hottest cases are. For instance having a v.isString() check + an inlined isAtom() call could be nice. ToAtom also isn't inlined...

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Patch

I instrumented the browser and on Speedometer > 80% of ValueToId calls have an atomized string. About 10% are non-atomized strings.

So here's a patch to handle these cases better in ValueToId and ValueToIdPure.

Not sure if we should make ValueToId MOZ_ALWAYS_INLINE...

Comment 3

[Tom S [:evilpie]]

Comment on attachment 8877684 [details] [diff] [review]
Patch

Stealing .. LGTM.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fd504b9feed
Optimize ValueToId and ValueToIdPure to check the common cases first. r=evilpie

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1fd504b9feed