1370213 - compare-locales should report non existent config files

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: compare-locales, defect)

Description

[Francesco Lodolo [:flod]]

While testing, I was misspelling the path to the config file when invoking compare-locales. 

Currently output is blank, I think it would make more sense to report at least an error.

Comment 1

[Axel Hecht [:Pike]]

This is the thing you talked about in bug 1361037 comment 36, missed that in the review process.

Comment 2

[Axel Hecht [:Pike]]

Attachment: bug 1370213, error on missing configuration files and bad l10n-base-dir,

Review commit: https://reviewboard.mozilla.org/r/147118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147118/

Comment 3

[Francesco Lodolo [:flod]]

Comment on attachment 8875685 [details]
bug 1370213, error on missing configuration files and bad l10n-base-dir,

https://reviewboard.mozilla.org/r/147118/#review151330

::: compare_locales/commands.py:124
(Diff revision 1)
>          args.l10n_base_dir = all_args.pop(0)
>          args.locales.extend(all_args)
>          configs = []
>          config_env = {}  # Hook up commandline arguments here
>          for config_path in args.config:
>              if config_path.endswith('.toml'):

This only fixes part of the problem (missing l10n-base path). The other is non existing config files. What about adding here?

if not os.path.isfile(config_path):
    self.parser.error('config file not found')

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 8875685 [details]
bug 1370213, error on missing configuration files and bad l10n-base-dir,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147118/diff/1-2/

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8875685 [details]
bug 1370213, error on missing configuration files and bad l10n-base-dir,

https://reviewboard.mozilla.org/r/147118/#review151404

Looks good, thanks. I stumbled that INI text the other day and completely forgot about it.

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 8875685 [details]
bug 1370213, error on missing configuration files and bad l10n-base-dir,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147118/diff/2-3/

Comment 7

[Axel Hecht [:Pike]]

https://hg.mozilla.org/l10n/compare-locales/rev/fca288f0e156fb7d2c5b57f08fce69d1b23fc092, FIXED.