1370278 - Grid Inspector should take in account ancestors transformation

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Matteo Ferretti [:zer0] [:matteo]]

Currently the Grid Inspector takes in account only the inspected element's transformations; we should consider all the ancestor transformations as well.

Basically, we need to implement in our code the new Chrome-only API implemented in bug 1355675.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Bug 1370278 - used `getTransformToAncestor` in Grid Inspector highlighter;

Used the new chrome-only API to obtain the transformation matrix of the current
node, relative to the inspected window's root element.
That also includes all the transformations from the element's ancestor; plus
the method is more robust and we can simplify the current code, removing also
some hack.

Review commit: https://reviewboard.mozilla.org/r/146640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146640/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8875223 [details]
Bug 1370278 - used `getTransformToAncestor` in Grid Inspector highlighter;

https://reviewboard.mozilla.org/r/146640/#review150668

We talked about this changes in a video call before. They seem fine to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b61c6809644c
used `getTransformToAncestor` in Grid Inspector highlighter; r=pbro

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing chrome test test_dom_matrix_2d.html with 'getNodeTransformOrigin is not a function':

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d4fe81a5f816b5bf67bca874431a2857b52f247

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b61c6809644c0f97872971957842f59736e6851d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=105574198&repo=mozilla-inbound

[task 2017-06-08T18:35:11.250221Z] 18:35:11     INFO - TEST-START | devtools/shared/tests/mochitest/test_dom_matrix_2d.html
[task 2017-06-08T18:35:11.281570Z] 18:35:11     INFO - TEST-INFO | started process screentopng
[task 2017-06-08T18:35:11.811405Z] 18:35:11     INFO - TEST-INFO | screentopng: exit 0
[task 2017-06-08T18:35:11.811738Z] 18:35:11     INFO - TEST-UNEXPECTED-FAIL | devtools/shared/tests/mochitest/test_dom_matrix_2d.html | uncaught exception - TypeError: getNodeTransformOrigin is not a function at testNodeTransformOrigin@chrome://mochitests/content/chrome/devtools/shared/tests/mochitest/test_dom_matrix_2d.html:50:18
[task 2017-06-08T18:35:11.811904Z] 18:35:11     INFO - @chrome://mochitests/content/chrome/devtools/shared/tests/mochitest/test_dom_matrix_2d.html:46:7
[task 2017-06-08T18:35:11.811943Z] 18:35:11     INFO - 
[task 2017-06-08T18:35:11.812030Z] 18:35:11     INFO - simpletestOnerror@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1652:11
[task 2017-06-08T18:35:11.812095Z] 18:35:11     INFO - OnErrorEventHandlerNonNull*@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1632:1

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8875223 [details]
Bug 1370278 - used `getTransformToAncestor` in Grid Inspector highlighter;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/146640/diff/1-2/

Comment 6

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8875223 [details]
Bug 1370278 - used `getTransformToAncestor` in Grid Inspector highlighter;

Gabriel, the review was already made by Patrick, here I just removed the test that was failing, since it's not necessary anymore – I explained why in my commit message, but feel free to ping me on IRC if you want to.

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8875223 [details]
Bug 1370278 - used `getTransformToAncestor` in Grid Inspector highlighter;

https://reviewboard.mozilla.org/r/146640/#review151572

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/908eeb65a000
used getTransformToAncestor in Grid Inspector highlighter; r=gl

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/908eeb65a000