Closed Bug 137029 Opened 23 years ago Closed 23 years ago

MathML entries are missing in embedding packages

Categories

(Core :: MathML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.0

People

(Reporter: rbs, Assigned: rbs)

Details

(Keywords: topembed+)

Attachments

(1 file, 1 obsolete file)

http://lxr.mozilla.org/seamonkey/find?string=basebrowser Also to fix while here: the XHTML DTD entries are missing too.
All the barsebrowser lists contain res/dtd/*, so all DTDs that the build puts there should be packaged. If there are some extra xpt/dll/rdf/etc. packages for MathML you may need to add those to appropriate places.
> All the barsebrowser lists contain res/dtd/* Ah OK, I now see. I missed them earlier.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
Attached patch fix for Windows & Unix (obsolete) — Splinter Review
[Other platforms (Mac) have not yet ported the GetBoundingMetrics function: http://www.mozilla.org/projects/mathml/enable.html]
what are some MathML URL's we can use to verify that it works in embedding samples?
There are some links to test documents from the MathML project page at http://www.mozilla.org/projects/mathml/ Dunno if they cover everything, though. Roger?
Yep, the tests (such as the Torture Test) are sufficient to trigger the particularities of MathML in the code base. e.g., stretchy characters won't stretch if |ucvmath| and |res/fons/*| aren't packaged. The style of scripts (subscript, superscript, accent, fraction, etc) won't reduce if |mathml.css| isn't packaged.
Note for the m1.0 branch: bug 135895 (a regression in XHTML) causes the MathML rendering on the m1.0 branch to not match with existing screenshots. (Bug 135895 is a regression w.r.t. <style> in XHTML. It was only fixed on the trunk so far.)
Roger : Any idea when Bug 135895 is going to be fixed on the Moz 1.0 branch..thanks
No clues. From my cursory reading of it, peterv has been awaiting ADT approval for some time now.
Seeking r=/sr= for the trunk so that I can check in there and ask for a= on the branch afterwards.
Summary: MathML entries are missing in embedding packages → [fix, awaiting r/sr/a] MathML entries are missing in embedding packages
Whiteboard: fix, awaiting r/sr/a
Comment on attachment 79387 [details] [diff] [review] fix for Windows & Unix This looks good to me, but shouldn't these be added to the Mac packages as well? Please check who have given r & sr earlier for packager changes via LXR, and email them for r/sr.
> This looks good to me mind giving r/sr to keep the ball rolling then? chak? adamlock? LXR shows your names. > but shouldn't these be added to the Mac packages as well? what do you think in light of comment #3?
Comment on attachment 79387 [details] [diff] [review] fix for Windows & Unix Can you move all the mathml specific stuff into a single block so it's easy to comment out? Also if you want to see MathML on that the Mac you'll need to patch the 3 mac files too. A further point. The embedding dist is not meant to be everything including the kitchen sink. It's a *sample* subset of Mozilla. I don't mind if MathML goes in but its worth bearing in mind for future submissions.
> The embedding dist is not meant to be everything including the kitchen sink. Oh la la... Check the "View Bug Activity" to see where the keywords came from. I am doing this patch on request.
Attached patch updated patchSplinter Review
Attachment #79387 - Attachment is obsolete: true
Comment on attachment 80819 [details] [diff] [review] updated patch r/sr=heikki If MathML is not built on Mac/does not work at all, then I am ok without the mac changes.
Attachment #80819 - Flags: superreview+
Comment on attachment 80819 [details] [diff] [review] updated patch r=adamlock
Attachment #80819 - Flags: review+
Checked in the trunk. Have asked drivers for approval on the branch.
Summary: [fix, awaiting r/sr/a] MathML entries are missing in embedding packages → [fix, awaiting a=] MathML entries are missing in embedding packages
Whiteboard: fix, awaiting r/sr/a → fix, checked in the trunk, awaiting a= for the branch
Now checked in the trunk and the 1.0 branch.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: fixed1.0.0
Resolution: --- → FIXED
Summary: [fix, awaiting a=] MathML entries are missing in embedding packages → MathML entries are missing in embedding packages
Whiteboard: fix, checked in the trunk, awaiting a= for the branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: