Closed Bug 1370328 Opened 3 years ago Closed 3 years ago

force plugins off and jsgc_poisoning for talos

Categories

(Testing :: Talos, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

Details

(Whiteboard: [PI:June])

Attachments

(1 file, 1 obsolete file)

after looking at some of our configurations, we determined that we ensure this pref is set in testing:
plugin.state.flash = 0

In addition, setting these environment variables:
JSGC_DISABLE_POISONING=1
MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 (this oddly seems to be removed from the test run, but not the warmup/initialization run)
Whiteboard: [PI:June]
Attached patch update prefs and env vars (obsolete) — Splinter Review
tested on try, compared results- will see a small win thanks to JSGC_DISABLE_POISONING; otherwise this seems to not change much.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8874550 - Flags: review?(rwood)
Comment on attachment 8874550 [details] [diff] [review]
update prefs and env vars

Review of attachment 8874550 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/talos/talos/ttest.py
@@ +103,5 @@
>              setup.env['MOZ_INSTRUMENT_EVENT_LOOP_THRESHOLD'] = '20'
>              setup.env['MOZ_INSTRUMENT_EVENT_LOOP_INTERVAL'] = '10'
>              global_counters['responsiveness'] = []
>  
> +        setup.env['JSGC_DISABLE_POISONING'] = '0'

JSGC_DISABLE_POISONING should be set to '1' correct?
Attachment #8874550 - Flags: review?(rwood) → review-
oh, I did this wrong on my try push, here is a try push and a baseline push:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=5492bf1b91c9&newProject=try&newRevision=fd685976b2ac64e987c73609842525e5d4a841ae&framework=1&showOnlyImportant=0

it will be a few hours before all the results are in, but this will be a change to see what =1 looks like :)
Attachment #8874749 - Flags: review?(rwood) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2737791ec8e
force plugins off and jsgc_poisoning for talos. r=rwood
https://hg.mozilla.org/mozilla-central/rev/f2737791ec8e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.