Closed Bug 1370334 Opened 3 years ago Closed 3 years ago

Port bug 1352366 to TB [Implement new location and search bar appearance]

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 55.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1352366 implemented a new (Photon) searchbox appearance we can follow.
Attached patch searchBar.patch (obsolete) — Splinter Review
This patch implements the new Photon appearance for our searchboxes (GloDa-search, QFB-search, Search in AB and for Calendar task- and event search) Other textboxes aren't affected.

I added all followup changes of bug 1352366 to this patch.

Aceman, can you check the whole code and the appearance on Linux?
Jörg, can you check the appearance on Windows?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8874553 - Flags: review?(jorgk)
Attachment #8874553 - Flags: review?(acelists)
Firefox hasn't yet shipped any of Photon in a release so we do not know the acceptance of it by users (just better do not ask me :)). Is it a good time to start dragging this into TB?
Our release will be TB 59. Until then we have only Betas. I have no problem to wait for 56 for this patch.

This styling of this boxes is not so different to the existing one and I'm sure it will stay. What I clearly don't like and don't want to follow are the new button hover styles (simple, flat background changes without any border).

I forgot to mention that I haven't followed the increased text size because it looks weird as our searchboxes aside of our buttons with their buttontext aren't the main UI like the URL bar.
Well, bug 1369999 was already a Photon thing, no?
Yes, but with no visual Photon change. The hovered menu change was initiated by me.
(In reply to Richard Marti (:Paenglab) from comment #1)
> This patch implements the new Photon appearance for our searchboxes
> (GloDa-search, QFB-search, Search in AB and for Calendar task- and event
> search) Other textboxes aren't affected.
Hmm, this seems to be another "spot the difference" bug. I applied the patch, and unless I messed up, there is no visible difference on Windows 7.
On Win7 the border color is slightly different and with LW-themes the background color opacity. On the other platforms where is also no big change. This is why I wrote this change will stay and won't be backed out in FX.
I would consider "no visible change" a positive feature :)
OK, I can see the border colour change now. And the blue border is now permanent, even if the caret is in the box.
(In reply to Jorg K (GMT+2) from comment #9)
> OK, I can see the border colour change now. And the blue border is now
> permanent, even if the caret is in the box.

When no focus on the box the border is grey and when focused it's blue, correct?
Windows 7 current behaviour:

Textbox not focused: border grey.
Textbox focused and caret inside: border grey, a tiny bit darker.
Textbox focused and caret outside: border blue.

With the patch:
Textbox not focused: border grey.
Textbox focused and caret inside: border blue, box with a little shadow, hard to see.
Textbox focused and caret outside: border blue.
It appears that when moving the caret out and back into the box, there is a tiny change in shadow of the border.
Sounds correct. You could also correlate with FX's search box if it behaves the same. But don't correlate the search glass icon. ;-) We still use the toolkit one. I'm thinking about using our own for more system consistency.
Comment on attachment 8874553 [details] [diff] [review]
searchBar.patch

Review of attachment 8874553 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see any difference so I'm fine. But can you also check the searchbox in the filter list dialog? Somehow it is more massive than the others, higher and with thicker border. Is that intentional?
Attachment #8874553 - Flags: review?(acelists) → review+
Attached patch searchBar.patchSplinter Review
(In reply to :aceman from comment #13)
> Comment on attachment 8874553 [details] [diff] [review]
> searchBar.patch
> 
> Review of attachment 8874553 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I don't see any difference so I'm fine. But can you also check the searchbox
> in the filter list dialog? Somehow it is more massive than the others,
> higher and with thicker border. Is that intentional?

This is because it doesn't use the styling from searchBox.css.

This patch is now with the filter list dialog included.
Attachment #8874553 - Attachment is obsolete: true
Attachment #8874553 - Flags: review?(jorgk)
Attachment #8874971 - Flags: review?(jorgk)
Attachment #8874971 - Flags: review?(acelists)
Comment on attachment 8874971 [details] [diff] [review]
searchBar.patch

Review of attachment 8874971 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks.
Attachment #8874971 - Flags: review?(acelists) → review+
Comment on attachment 8874971 [details] [diff] [review]
searchBar.patch

Not very exiting but it does what it should as detailed in comment #11.
Attachment #8874971 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/502e9f359c37e2713aa5c5170864a978ab664764
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in before you can comment on or make changes to this bug.