Closed
Bug 1370381
Opened 7 years ago
Closed 7 years ago
Remove non-JS Cargo.toml files when bundling SM tarballs
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file)
|
1.38 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
There are a bunch of invalid Cargo.toml files that some python stuff uses for testing, but these cause errors out of cargo when we point to one of the SM source tarballs as a git dependency. Easiest workaround is to not include any non-SpiderMonkey Cargo.toml files in the source tarballs.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8874612 -
Flags: review?(sphink)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → nfitzgerald
|
|
Assignee | |
Comment 2•7 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ac8bec65a7dc07a10a7abedbbc226600b7a7587
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8874612 [details] [diff] [review] Remove non-JS Cargo.toml files when bundling SM tarballs Review of attachment 8874612 [details] [diff] [review]: ----------------------------------------------------------------- Heh. That's a nuisance.
Attachment #8874612 -
Flags: review?(sphink) → review+
Pushed by nfitzgerald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8d0269a6e464 Remove non-JS Cargo.toml files when bundling SM tarballs; r=sfink
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8d0269a6e464
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•