Closed Bug 1370453 Opened 2 years ago Closed 2 years ago
Potential race condition in Then
59 bytes, text/x-review-board-request
http://searchfox.org/mozilla-central/rev/d441cb24482c2e5448accaf07379445059937080/xpcom/threads/MozPromise.h#953-958 MozPromiseRequestHolder is not thread-safe and it is possible for mReceiver->ThenInternal() to trigger resolve/reject callbacks before aRequestHolder.Track() is run. We should call aRequestHolder.Track() before mReceiver->ThenInternal() to avoid the race condition.
Attachment #8875096 - Flags: review?(gsquelart)
Comment on attachment 8875096 [details] Bug 1370453 - fix potential race condition in ThenCommand<>::Track(). https://reviewboard.mozilla.org/r/146478/#review150468
Attachment #8875096 - Flags: review?(gsquelart) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/4d5d122b04ea fix potential race condition in ThenCommand<>::Track(). r=gerald
You need to log in before you can comment on or make changes to this bug.