1370453 - Potential race condition in ThenCommand<>::Track()

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/d441cb24482c2e5448accaf07379445059937080/xpcom/threads/MozPromise.h#953-958

MozPromiseRequestHolder is not thread-safe and it is possible for mReceiver->ThenInternal() to trigger resolve/reject callbacks before aRequestHolder.Track() is run.

We should call aRequestHolder.Track() before mReceiver->ThenInternal() to avoid the race condition.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1370453 - fix potential race condition in ThenCommand<>::Track().

http://searchfox.org/mozilla-central/rev/d441cb24482c2e5448accaf07379445059937080/xpcom/threads/MozPromise.h#953-958

MozPromiseRequestHolder is not thread-safe and it is possible for
mReceiver->ThenInternal() to trigger resolve/reject callbacks before
aRequestHolder.Track() is run. We should call aRequestHolder.Track()
before mReceiver->ThenInternal() to avoid the race condition.

Review commit: https://reviewboard.mozilla.org/r/146478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146478/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8875096 [details]
Bug 1370453 - fix potential race condition in ThenCommand<>::Track().

https://reviewboard.mozilla.org/r/146478/#review150468

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d5d122b04ea
fix potential race condition in ThenCommand<>::Track(). r=gerald

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d5d122b04ea