1370463 - Xenforo editor only loads when Devtools are open

Status: REOPENED

(Core :: JavaScript Engine, defect, P3)

Description

[TMart]

Attachment: xenforo_editor.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170605030204

Steps to reproduce:

Open a discussion board using Xenforo. 

For example: 
www.android-hilfe.de/
www.gamestar.de/xenforo/

Either try to quick-answer via editor or reply on an extra page. 


Actual results:

The text field of the editor stays inactive. 

DevTools give a TypeError: 'this.$editor[0] is undefined', linking to the following page: https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Fehler/Unexpected_type

See also attached screenshot. 

The editor only loads as long as the DevTools are open. 


Expected results:

Text input loads without the DevTools being open.

Comment 1

[TMart]

Could this have anything to do with the following patch landing? It broke two days ago. 

https://bugzilla.mozilla.org/show_bug.cgi?id=1300590

Comment 2

[TMart]

Did some more testing because it works with a fresh profile: Foxy Gestures 1.02 seems to be the cause. It doesn't work as long as Foxygestures is activated.

Comment 3

[TMart]

Smartup Gestures is affected: https://addons.mozilla.org/de/firefox/addon/smartup/

Mouse Gesture Events isn't affected: https://addons.mozilla.org/en-US/firefox/addon/mouse-gestures/

Comment 4

[TMart]

Bisection: 

2017-06-08T13:02:36: DEBUG : Found commit message:
Bug 1368152: Part 4 - Remove ExtensionManagement.jsm. r=aswan

MozReview-Commit-ID: Apbi1QYeb2x

Comment 5

[mark]

I'm the developer of Foxy Gestures and I have reproduced this issue with Nightly.

Steps to reproduce in Nightly are:

1) Make sure devtools are closed.
2) Create a Xenforo demo forum: https://xenforo.com/demo/
3) Login using "admin" for username and password.
4) Create a new topic or reply to a topic. The problem is triggered by the post/reply editor. When the issue occurs, the port/reply editor will appear disabled.

The editor seems to be built with https://imperavi.com/redactor/.

In fact, every page load in Nightly is generating an exception in the console when Foxy Gestures or smartUp Gestures is enabled:

[Exception... "Must have a non-null string spec or nsIFile object"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: resource://gre/modules/ExtensionParent.jsm :: ProxyContextParent :: line 307"  data: no]

Comment 6

[mark]

Attachment: Screenshot of the browser console with errors

Here is a screenshot of the browser console with errors.

[Exception... "Must have a non-null string spec or nsIFile object" error is appearing on every page load when Foxy Gestures or smartUp gestures is enabled.

Comment 7

[TMart]

As expected Firefox 55 Beta 1 Candidates are affected by this.

Comment 8

[TMart]

Is there any information I can provide to get this going? Or is this just not a priority right now?

Comment 9

[Jan de Mooij [:jandem]]

NI kmag based on comment 4.

Comment 11

[TMart]

This is not fixed for me by https://bugzilla.mozilla.org/show_bug.cgi?id=1374129. 

Still getting a TypeError: this.$editor[0] is undefined in the console and reply editor is not loading on Xenforo when Foxy Gestures is enabled.

Comment 12

[Kris Maglione [:kmag]]

OK, then there may be other issues involved as well.

Comment 13

[TMart]

I have to take that back, sorry for the false alarm. It seems to be fixed now. Probably got the wrong build ID for testing.

Comment 14

[TMart]

And now it's broken again. Same error in redactor.js. 

Tried a bisection between today and three days ago, all builds are bad again. There must be some other variable involved, but I have no idea what that could be in a new profile.

Comment 15

[TMart]

Sorry, have to push this again. 

It is working constantly in Nightly on my desktop now, but still not working on my laptop. Both running the latest version of Windows 10, the latest version of Nightly, the same addons (synced with Firefox Sync). 

I completely deleted the profile and program folder of Nightly on my laptop and reinstalled it, the problem persists even with a completely new profile and Sync not yet enabled. Is there some other variable I'm not seeing here? How can the Javascript run on one system, but fail on the other? 

It is fixed on none of my systems with Firefox 55 Beta 7.

Comment 16

[Nate Burton]

Attachment: same problem

Thanks from gasimdabbse1976.